From: Linus Torvalds <torvalds@osdl.org>
To: John Ellson <ellson@research.att.com>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] rpmbuild doesn't like '-' in version strings
Date: Sat, 14 Jan 2006 09:53:19 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0601140951230.13339@g5.osdl.org> (raw)
In-Reply-To: <43C91B25.9030707@research.att.com>
On Sat, 14 Jan 2006, John Ellson wrote:
>
> What happened to this? I don't particularly like my fix either, but
> some kind of fix is needed for the "make rpm" target to work. Its still
> broken because of the '-' in the version string.
Do a "sed" for rpmbuild.
There's absolutely no point in trying to make git-describe use "_" instead
of "-", since having a "-" in a tag-name is very common ("my-version"),
and it would be a horrible mistake to munge the tag-names. So even if we
changed "-g" into "_g" it wouldn't help anything, and just make things
uglier.
This is an RPM versioning problem, and nothing more. So it should be
handled by rpmbuild.
Linus
next prev parent reply other threads:[~2006-01-14 17:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-30 17:29 [PATCH] rpmbuild doesn't like '-' in version strings John Ellson
2006-01-06 22:37 ` Junio C Hamano
2006-01-07 0:04 ` Andreas Ericsson
2006-01-07 0:47 ` Johannes Schindelin
2006-01-07 1:22 ` Ryan Anderson
2006-01-14 15:39 ` John Ellson
2006-01-14 17:53 ` Linus Torvalds [this message]
2006-01-14 19:17 ` Junio C Hamano
2006-01-14 20:25 ` John Ellson
2006-01-14 20:35 ` Junio C Hamano
2006-01-16 9:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0601140951230.13339@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=ellson@research.att.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).