From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Marco Costalba <mcostalba@yahoo.it>, git@vger.kernel.org
Subject: Re: Possible git-rev-list bug
Date: Tue, 31 Jan 2006 07:55:53 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0601310745270.7301@g5.osdl.org> (raw)
In-Reply-To: <7vmzhekcz3.fsf@assigned-by-dhcp.cox.net>
On Sun, 29 Jan 2006, Junio C Hamano wrote:
> Marco Costalba <mcostalba@yahoo.it> writes:
>
> > $ git-rev-list --max-count=1 --parents addafaf92eeb86033da91323d0d3ad7a496dae83 -- rev-list.c
> > addaf.. d8f6b.. 93b74.. d8f6b.. d8f6b.. 3815f..
> >
> > We have the same parent (d8f6b..) multiple times.
>
> I think it probably is a bug.
Well, it's not strictly a bug, and multiple of the same parents _can_
happen in real life due to buggy commits, so a tool that depends on some
kind of parent uniqueness are a bit fragile. There is nothing fundamental
in the git data structures that says that you couldn't have the same
parent twice.
In this case, it didn't start out with the same parent - we had five
unique parents, but by the time the tree had been simplified, some of them
had become common.
So I don't know if it's a "bug", and the bad reaction by gitk and qgit are
arguably the _real_ bugs.
But Junio's patch is simple, and perhaps the right thing to do.
Linus
prev parent reply other threads:[~2006-01-31 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-29 9:41 Possible git-rev-list bug Marco Costalba
2006-01-29 20:15 ` Junio C Hamano
2006-01-29 23:30 ` [PATCH] rev-list: omit duplicated parents Junio C Hamano
2006-01-31 15:55 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0601310745270.7301@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=mcostalba@yahoo.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).