From: Linus Torvalds <torvalds@osdl.org>
To: Aneesh Kumar <aneesh.kumar@gmail.com>
Cc: Marco Costalba <mcostalba@gmail.com>,
Junio C Hamano <junkio@cox.net>,
Git Mailing List <git@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
Marco Costalba <mcostalba@yahoo.it>
Subject: Re: The merge from hell...
Date: Thu, 2 Feb 2006 00:44:35 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0602020027400.21884@g5.osdl.org> (raw)
In-Reply-To: <cc723f590602020007s43f89d10i4529d118ade7c764@mail.gmail.com>
On Thu, 2 Feb 2006, Aneesh Kumar wrote:
>
> Ok i tried using --cc. But then as per the man page if the
> optimization makes the all the hunks disapper then commit log is not
> show unless -m is used.
Ahh. You're mis-using git-diff-tree.
git-diff-tree will _never_ show the commit log if the diff ends up being
empty. That can actually happen even for a regular commit, because we had
some early bugs that allowed them.
See commit 69d37960b578be0a69383bd71d06c1fcfb86e8b9, for example. Notice
how
git-diff-tree --pretty 69d37960
is entirely silent, even though
git log 69d37960
clearly shows that the commit exists. I screwed up a commit, and
effectively applied an empty patch (this was before git-apply would
notice, and consider it an error - something I fixed very soon
afterwards ;^).
> Is there a way to get the commit log printed.
Yes. What you should do is to do
git-rev-list --parents --pretty
which gives the revision _log_ in pretty format.
The difference between "git-rev-list --pretty" and "git-diff-tree
--pretty" is really exactly that "git-rev-list" lists every revision,
while git-diff-tree only lists revisions that _differ_ in the trees.
This, btw, is also really the main difference between doing a "git log"
and doing a "git whatchanged". A "git log" shows all revisions (and uses
"git-rev-list --pretty"). While "git whatchanged" shows what _changed_
(and uses "git-diff-tree --pretty").
For a revision tool like gitview, you want to use "git-rev-list --pretty".
[ SIDE NOTE! Actually, there's another format that you may find easier to
parse automatically: "git-rev-list --header". It uses the raw format,
and adds a NUL character between each rev. That makes things like the
date etc trivial to parse, and it's also slightly easier to see the end
of a commit message vs just a normal end-of-line.
So "gitk", for example, really parses the output of
git-rev-list --header --topo-order --parents
to generate the revision list. The "--topo-order" part guarantees that
all children will always be shown before any parents. ]
Hope that clarifies the issue.
Linus
next prev parent reply other threads:[~2006-02-02 8:45 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-02 6:28 The merge from hell Linus Torvalds
2006-02-02 7:05 ` Junio C Hamano
2006-02-02 7:40 ` [PATCH] combine-diff: reuse diff from the same blob Junio C Hamano
2006-02-02 7:51 ` The merge from hell Linus Torvalds
2006-02-02 7:55 ` Linus Torvalds
2006-02-02 8:08 ` Linus Torvalds
2006-02-02 8:18 ` [PATCH] combine-diff: update --cc "uninteresting hunks" logic Junio C Hamano
2006-02-02 9:34 ` [PATCH] combine-diff: add safety check to --cc Junio C Hamano
2006-02-02 23:03 ` Linus Torvalds
2006-02-03 0:02 ` Junio C Hamano
2006-02-03 1:05 ` Linus Torvalds
2006-02-03 5:49 ` [Attn - repository browser authors] diff-tree combined format Junio C Hamano
2006-02-03 12:17 ` Marco Costalba
2006-02-03 19:55 ` Junio C Hamano
2006-02-03 21:35 ` Junio C Hamano
2006-02-04 12:03 ` Marco Costalba
2006-02-04 11:23 ` Paul Mackerras
2006-02-03 5:28 ` [PATCH] combine-diff: add safety check to --cc Junio C Hamano
2006-02-04 5:38 ` Paul Mackerras
2006-02-04 6:12 ` Junio C Hamano
2006-02-04 10:46 ` The merge from hell Paul Mackerras
2006-02-04 12:22 ` Junio C Hamano
2006-02-04 19:42 ` Linus Torvalds
2006-02-04 20:59 ` Linus Torvalds
2006-02-02 7:25 ` Marco Costalba
2006-02-02 8:02 ` Linus Torvalds
2006-02-02 8:07 ` Aneesh Kumar
2006-02-02 8:27 ` Junio C Hamano
2006-02-02 8:44 ` Linus Torvalds [this message]
2006-02-02 10:41 ` Junio C Hamano
2006-02-05 19:42 ` Linus Torvalds
2006-02-05 19:49 ` Add a "git show" command to show a commit Linus Torvalds
2006-02-05 19:58 ` Fix git-rev-parse over-eager errors Linus Torvalds
2006-02-05 20:11 ` Junio C Hamano
2006-02-05 22:03 ` Linus Torvalds
2006-02-06 6:20 ` Junio C Hamano
2006-02-05 22:45 ` Add a "git show" command to show a commit Junio C Hamano
2006-02-05 22:55 ` Linus Torvalds
2006-02-05 22:59 ` Linus Torvalds
2006-02-06 0:25 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2006-02-03 4:20 The merge from hell Brown, Len
2006-02-03 5:45 ` Linus Torvalds
2006-02-03 6:28 ` Junio C Hamano
2006-02-03 16:21 ` Dave Jones
2006-02-03 6:04 Brown, Len
2006-02-03 6:16 ` Linus Torvalds
2006-02-03 6:33 ` Junio C Hamano
2006-02-03 6:41 linux
2006-02-03 18:34 Brown, Len
2006-02-04 2:35 ` Junio C Hamano
2006-02-04 2:47 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0602020027400.21884@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=aneesh.kumar@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=mcostalba@gmail.com \
--cc=mcostalba@yahoo.it \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).