git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Ryan Anderson <ryan@michonline.com>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] Add git-annotate - a tool for annotating files with the revision and person that created each line in the file.
Date: Wed, 8 Feb 2006 11:09:16 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0602081058210.2458@g5.osdl.org> (raw)
In-Reply-To: <11394103753694-git-send-email-ryan@michonline.com>



On Wed, 8 Feb 2006, Ryan Anderson wrote:
> 
> I think this version is mostly ready to go.

Hmm.. I get

   [torvalds@g5 git]$ ./git-annotate Makefile
   fatal: 'e83c5163316f89bfbde7d9ab23ca2e25604af290^1..e83c5163316f89bfbde7d9ab23ca2e25604af290': No such file or directory
   Undefined subroutine &main::all_lines_claimed called at ./git-annotate line 124.

where that fatal error is because e83c51.. doesn't _have_ a parent, it's 
the root (so doing ^1 on it doesn't work).

After fixing the "all_lines_claimed" problem as outlined by Dscho, I get a 
lot of

	Skipping diff-parse - i = filelines)

and no actual output.

Doing it on a file that didn't exist in the root commit still have those 
"Skipping" messages, but at least it did actually output something. 

However, what it output was clearly not correct, so there's still some 
tweaking to do.

For example, doing

	./git-annotate apply.c

annotates most of that file to Junio's commit 1c15afb9, which is totally 
incorrect, that commit actually only changed a few lines.

So it looks like there's still some work to be done on this..

			Linus

  parent reply	other threads:[~2006-02-08 19:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-08 14:52 [PATCH] Add git-annotate - a tool for annotating files with the revision and person that created each line in the file Ryan Anderson
2006-02-08 15:09 ` Peter Eriksen
2006-02-08 16:05   ` Johannes Schindelin
2006-02-08 16:35 ` Franck Bui-Huu
2006-02-08 17:45   ` Johannes Schindelin
2006-02-08 19:19     ` Junio C Hamano
2006-02-10 11:25       ` Ralf Baechle
2006-02-10 11:55         ` Andreas Ericsson
2006-02-14 10:51         ` Fredrik Kuivinen
2006-02-08 18:47   ` Randal L. Schwartz
2006-02-09  9:19     ` Andreas Ericsson
2006-02-09  9:57       ` Junio C Hamano
2006-02-09 12:04         ` Franck Bui-Huu
2006-02-09 12:47           ` Andreas Ericsson
2006-02-08 19:09 ` Linus Torvalds [this message]
2006-02-08 19:51 ` Junio C Hamano
2006-02-08 21:07   ` Ryan Anderson
2006-02-08 21:45     ` Junio C Hamano
2006-02-10 22:04       ` Ryan Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0602081058210.2458@g5.osdl.org \
    --to=torvalds@osdl.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=ryan@michonline.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).