From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] binary-tree-based objects.
Date: Sat, 11 Feb 2006 21:22:35 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0602112117560.3691@g5.osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0602112045340.3691@g5.osdl.org>
On Sat, 11 Feb 2006, Linus Torvalds wrote:
>
> Before:
> real 0m41.322s user 0m40.612s sys 0m0.492s
> real 0m40.797s user 0m40.140s sys 0m0.468s
> real 0m40.433s user 0m40.016s sys 0m0.412s
>
> After:
> real 0m22.542s user 0m22.080s sys 0m0.448s
> real 0m22.660s user 0m22.336s sys 0m0.312s
> real 0m22.671s user 0m22.236s sys 0m0.292s
And just so you wouldn't think that all my machines are slow..
Before:
real 0m28.645s user 0m28.366s sys 0m0.280s
real 0m28.700s user 0m28.486s sys 0m0.212s
After:
real 0m16.566s user 0m16.373s sys 0m0.196s
real 0m16.512s user 0m16.277s sys 0m0.236s
so there (that's all with current kernel HEAD, mostly packed).
Now, I haven't compared it to the other suggested fixes (hashing, and the
256-way bucket-sorting), but I obviously prefer the tree approach because
it's my idea (and my ideas are _always_ superior) and because it's so dang
simple.
If somebody shows that the other approaches are faster, then I guess I'll
just have to sulk in a corner and grown quietly at people.
Linus
next prev parent reply other threads:[~2006-02-12 5:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-11 19:14 [PATCH] Optimization for git-rev-list --objects Alexandre Julliard
2006-02-12 1:57 ` [PATCH] Use a hashtable for objects instead of a sorted list Johannes Schindelin
2006-02-12 2:46 ` Junio C Hamano
2006-02-12 8:52 ` Alexandre Julliard
2006-02-12 12:11 ` Junio C Hamano
2006-02-12 14:31 ` Johannes Schindelin
2006-02-12 11:19 ` Florian Weimer
2006-02-12 12:08 ` ***DONTUSE*** " Junio C Hamano
2006-02-12 13:46 ` Junio C Hamano
2006-02-12 17:26 ` Johannes Schindelin
2006-02-12 18:34 ` Junio C Hamano
2006-02-12 2:19 ` [PATCH] Optimization for git-rev-list --objects Linus Torvalds
2006-02-12 2:39 ` Junio C Hamano
2006-02-12 4:11 ` [PATCH] binary-tree-based objects Junio C Hamano
2006-02-12 5:06 ` Linus Torvalds
2006-02-12 5:22 ` Linus Torvalds [this message]
2006-02-12 5:23 ` Linus Torvalds
2006-02-12 5:48 ` Junio C Hamano
2006-02-12 6:07 ` Junio C Hamano
2006-02-12 6:53 ` Linus Torvalds
2006-02-12 7:05 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0602112117560.3691@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).