From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>,
Git Mailing List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: Fix object re-hashing
Date: Sun, 12 Feb 2006 10:10:02 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0602121006360.3691@g5.osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0602120956130.3691@g5.osdl.org>
On Sun, 12 Feb 2006, Linus Torvalds wrote:
>
> I actually didn't see any of this trigger in real life, so maybe my
> analysis is wrong. Junio? Johannes?
Btw, if it does trigger, the behaviour would be that a subsequent object
lookup will fail, because the last old slot would be NULL, and a few
entries following it (likely just a couple - never mind that the event
triggering in the first place is probably fairly rare) wouldn't have
gotten re-hashed down.
As a result, we'd allocate a new object, and have _two_ "struct object"s
that describe the same real object. I don't know what would get upset, but
git-fsck-index certainly would be (one of them would likely be marked
unreachable, because lookup wouldn't find it, but you might have other
issues too).
Linus
next prev parent reply other threads:[~2006-02-12 18:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-12 18:04 Fix object re-hashing Linus Torvalds
2006-02-12 18:10 ` Linus Torvalds [this message]
2006-02-12 18:32 ` Junio C Hamano
2006-02-12 18:53 ` Linus Torvalds
2006-02-12 19:10 ` Linus Torvalds
2006-02-12 19:21 ` Junio C Hamano
2006-02-12 19:39 ` Linus Torvalds
2006-02-12 23:55 ` Johannes Schindelin
2006-02-13 0:16 ` Linus Torvalds
2006-02-13 0:31 ` Johannes Schindelin
2006-02-12 19:13 ` Junio C Hamano
2006-02-12 18:16 ` Linus Torvalds
2006-02-12 18:18 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0602121006360.3691@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).