git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fetch-clone progress: finishing touches.
Date: Sun, 12 Feb 2006 12:37:08 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0602121230370.3691@g5.osdl.org> (raw)
In-Reply-To: <7vslqpjq2q.fsf@assigned-by-dhcp.cox.net>



On Sat, 11 Feb 2006, Junio C Hamano wrote:
> 
>  * While we are doing eye-candy, this makes the silence after
>    "Generating pack..." part a bit more bearable.
> 
>    Likes, dislikes, too-much's?

Too little, actually.

Your change makes

	git clone ssh://...

be silent again, until the download actually starts. The "isatty(2)" thing 
in git-pack-objects won't trigger, because it's actually a socket, not a 
tty ;/

ssh will only set up a pty pair if it starts an interactive shell, not if 
you use the "ssh host cmd" form.

		Linus

  parent reply	other threads:[~2006-02-12 20:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-11 18:43 Make "git clone" pack-fetching download statistics better Linus Torvalds
2006-02-12  1:58 ` [PATCH] fetch-clone progress: finishing touches Junio C Hamano
2006-02-12  3:01   ` Linus Torvalds
2006-02-12 20:37   ` Linus Torvalds [this message]
2006-02-12 21:50     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0602121230370.3691@g5.osdl.org \
    --to=torvalds@osdl.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).