From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org, paul@hibernia.jakma.org
Subject: Re: On recording renames
Date: Sat, 4 Mar 2006 09:36:09 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0603040929540.22647@g5.osdl.org> (raw)
In-Reply-To: <7v8xrqqrdd.fsf@assigned-by-dhcp.cox.net>
On Sat, 4 Mar 2006, Junio C Hamano wrote:
>
> An ideal merge strategy would handle the case where pieces of
> code gradually moves around across file boundaries. I do not
> think this is something you can sensibly do by recording file
> rename history. It would not help the situation a bit even if
> you gave each file (or content or object or whatever you want to
> call it) a persistent ID.
Actually, we have an absolutely perfect example of this much closer to
home.
I originally did the "rev-list split" series on an older version of git,
before you did the --objects-edge and the full pathname hashing
improvements. But when I was done, you'd merged that, and I needed to
merge my rev-list.c split with your improvements in order to send it to
you.
Now, the whold file hadn't actually been renamed, but about 50% of that
file had been split into a new one. So effectively you had a merge where
part of the new stuff had to be merged into another file.
Now, I think this is actually more common than renames in many ways. It's
not a "complete" rename, but as far as _part_ of your changes were
concerned, it was one.
And yes, such a split can be something that is done in stages, again
exactly the same way about 85% of rev-list.c was moved into revision.c in
two stages: the first stage was the argument parsing and setup, and the
second stage was the actual revision walking logic.
Linus
prev parent reply other threads:[~2006-03-04 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-04 4:03 On recording renames Junio C Hamano
2006-03-04 4:09 ` Paul Jakma
2006-03-04 6:16 ` Junio C Hamano
2006-03-04 13:19 ` Junio C Hamano
2006-03-04 17:36 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0603040929540.22647@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=paul@hibernia.jakma.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).