[PATCH] Use core.sharedrepository consistently.

[PATCH] Use core.sharedrepository consistently.

[Fernando J. Pereda]

[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]

'git init-db --shared' sets 'core.sharedRepository' but in
setup.c 'core.sharedrepository' is checked instead. This
trivial patch makes both init-db.c and its documentation to
use 'core.sharedrepository'.

Signed-off-by: Fernando J. Pereda <ferdy@gentoo.org>

---

 Documentation/git-init-db.txt |    2 +-
 init-db.c                     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

531df8e5c78ca67746b7a651ac4486eae8b114c6
diff --git a/Documentation/git-init-db.txt b/Documentation/git-init-db.txt
index ea4d849..2d818d6 100644
--- a/Documentation/git-init-db.txt
+++ b/Documentation/git-init-db.txt
@@ -34,7 +34,7 @@ environment variable then the sha1 direc
 otherwise the default `$GIT_DIR/objects` directory is used.
 
 A shared repository allows users belonging to the same group to push into that
-repository. When specifying `--shared` the config variable "core.sharedRepository" 
+repository. When specifying `--shared` the config variable "core.sharedrepository"
 is set to 'true' so that directories under `$GIT_DIR` are made group writable
 (and g+sx, since the git group may be not the primary group of all users).
 
diff --git a/init-db.c b/init-db.c
index ff29496..e77a749 100644
--- a/init-db.c
+++ b/init-db.c
@@ -285,7 +285,7 @@ int main(int argc, char **argv)
 	safe_create_dir(path, 1);
 
 	if (shared_repository)
-		git_config_set("core.sharedRepository", "true");
+		git_config_set("core.sharedrepository", "true");
 
 	return 0;
 }
-- 
1.2.4


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] Use core.sharedrepository consistently.

[Fernando J. Pereda]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

On Sat, Mar 04, 2006 at 11:51:25PM +0100, Fernando J. Pereda wrote:
> [snip]

Nevermind that one... I screwed almost every possible header in my mail.
Sorry.

-- 
Fernando J. Pereda Garcimartín
Gentoo Developer (Alpha,net-mail,mutt,git)
20BB BDC3 761A 4781 E6ED  ED0B 0A48 5B0C 60BD 28D4

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

[PATCH] Use core.sharedrepository consistently.

[Fernando J. Pereda]

[-- Attachment #1: Type: text/plain, Size: 1521 bytes --]

'git init-db --shared' sets 'core.sharedRepository' but in
setup.c 'core.sharedrepository' is checked instead. This
trivial patch fixes both init-db.c and its documentation to
use 'core.sharedrepository'.

Signed-off-by: Fernando J. Pereda <ferdy@gentoo.org>

---

 Documentation/git-init-db.txt |    2 +-
 init-db.c                     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

531df8e5c78ca67746b7a651ac4486eae8b114c6
diff --git a/Documentation/git-init-db.txt b/Documentation/git-init-db.txt
index ea4d849..2d818d6 100644
--- a/Documentation/git-init-db.txt
+++ b/Documentation/git-init-db.txt
@@ -34,7 +34,7 @@ environment variable then the sha1 direc
 otherwise the default `$GIT_DIR/objects` directory is used.
 
 A shared repository allows users belonging to the same group to push into that
-repository. When specifying `--shared` the config variable "core.sharedRepository" 
+repository. When specifying `--shared` the config variable "core.sharedrepository"
 is set to 'true' so that directories under `$GIT_DIR` are made group writable
 (and g+sx, since the git group may be not the primary group of all users).
 
diff --git a/init-db.c b/init-db.c
index ff29496..e77a749 100644
--- a/init-db.c
+++ b/init-db.c
@@ -285,7 +285,7 @@ int main(int argc, char **argv)
 	safe_create_dir(path, 1);
 
 	if (shared_repository)
-		git_config_set("core.sharedRepository", "true");
+		git_config_set("core.sharedrepository", "true");
 
 	return 0;
 }
-- 
1.2.4

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] Use core.sharedrepository consistently.

[Linus Torvalds]

On Sat, 4 Mar 2006, Fernando J. Pereda wrote:
>
> 'git init-db --shared' sets 'core.sharedRepository' but in
> setup.c 'core.sharedrepository' is checked instead.

It really shouldn't matter.

Case in a git config option name is always converted to lower case when 
the config file is read, exactly so that you can use mixed case without 
the actual readers caring. Lots of people prefer mixed-case for 
human-readable info, ie

	[Core]
		Name=Linus Torvalds

will actually generate

	core.name=Linus Torvalds

as the config variable.

So the code should have worked fine.  Unless there is some bug somewhere.

		Linus

Re: [PATCH] Use core.sharedrepository consistently.

[Junio C Hamano]

"Fernando J. Pereda" <ferdy@gentoo.org> writes:

> 'git init-db --shared' sets 'core.sharedRepository' but in
> setup.c 'core.sharedrepository' is checked instead.

I thought they were case insensitive..