From: Linus Torvalds <torvalds@osdl.org>
To: Matthias Urlichs <smurf@smurf.noris.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Don't recurse into parents marked uninteresting.
Date: Wed, 8 Mar 2006 21:48:00 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0603082144450.32577@g5.osdl.org> (raw)
In-Reply-To: <pan.2006.03.09.04.04.34.617873@smurf.noris.de>
On Thu, 9 Mar 2006, Matthias Urlichs wrote:
>
> revision.c:make_parents_uninteresting() is exponential with the number
> of merges in the tree. That's fine -- unless some other part of git
> already has pulled the whole commit tree into memory ...
Good call.
However, I would have expected the normal case to be that we haven't even
parsed the parent yet (as per the comment), so the parent normally
shouldn't even have the parent pointer (due to not having been parsed).
So what was it that triggered this "parents had already been parsed"
situation? Is it because we've generated a huge list of "I have it"
objects when pulling? That would explain it..
Linus
next prev parent reply other threads:[~2006-03-09 5:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-08 20:04 endless loop: ? Matthias Urlichs
2006-03-09 4:04 ` [PATCH] Don't recurse into parents marked uninteresting Matthias Urlichs
2006-03-09 5:48 ` Linus Torvalds [this message]
2006-03-09 10:20 ` smurf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0603082144450.32577@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=smurf@smurf.noris.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).