git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Fredrik Kuivinen <freku045@student.liu.se>, git@vger.kernel.org
Subject: Re: git-diff-tree -M performance regression in 'next'
Date: Sun, 12 Mar 2006 17:31:39 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0603121730310.3618@g5.osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0603121710110.3618@g5.osdl.org>



On Sun, 12 Mar 2006, Linus Torvalds wrote:
>
> 	u64 value = *(u64 *)src;
> 	src += 8;
> 	hash = value % 4294967291u;

Btw, this assumes the "only hash every 8 bytes" at the source, in which 
case this is ok even on architectures that need aligned reads. For the 
non-aligned reads, you'd need your "shift the value" approach.

		Linus

  reply	other threads:[~2006-03-13  1:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-11 17:28 git-diff-tree -M performance regression in 'next' Fredrik Kuivinen
2006-03-12  3:10 ` Junio C Hamano
2006-03-12 12:28 ` Junio C Hamano
2006-03-12 17:00   ` Linus Torvalds
2006-03-12 19:34     ` Junio C Hamano
2006-03-13  0:42       ` Junio C Hamano
2006-03-13  1:09         ` Linus Torvalds
2006-03-13  1:22           ` Junio C Hamano
2006-03-13  1:39             ` Linus Torvalds
2006-03-13  1:29           ` Linus Torvalds
2006-03-13  1:31             ` Linus Torvalds [this message]
2006-03-13  2:29             ` Linus Torvalds
2006-03-13  2:53               ` Linus Torvalds
2006-03-13  4:14             ` Junio C Hamano
2006-03-14  2:55               ` Junio C Hamano
2006-03-14  3:47                 ` Linus Torvalds
2006-03-14 10:26                   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0603121730310.3618@g5.osdl.org \
    --to=torvalds@osdl.org \
    --cc=freku045@student.liu.se \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).