From: Linus Torvalds <torvalds@osdl.org>
To: Mark Wooding <mdw@distorted.org.uk>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add ALL_LDFLAGS to the git target.
Date: Tue, 28 Mar 2006 15:03:05 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0603281500280.15714@g5.osdl.org> (raw)
In-Reply-To: <slrne2jf9t.s3g.mdw@metalzone.distorted.org.uk>
On Tue, 28 Mar 2006, Mark Wooding wrote:
> Jason Riedy <ejr@EECS.Berkeley.EDU> wrote:
>
> > P.S. For the whole finding-a-function-name business, some of
> > us are using git on fixed-format Fortran. Every non-comment
> > line begins with whitespace... ;) And in free format, many
> > people don't add that first indentation within subroutines.
>
> Urgh. So, which regex library do people want to use? ;-) (My vote's
> for pcre.)
I'd really just prefer to make the "-p" switch configurable, the way it
was before. No regexps, just the same rules as for GNU diff, perhaps with
the difference being that it would be on by default.
Another possible approach is to say
- if the first line of the real diff matches the rules, do NOT add
another line that matches the rule at the @@-line.
since the simple @@-line rule really doesn't make sense for any file that
is "dense" (ie where most lines start with non-whitespace).
Linus
next prev parent reply other threads:[~2006-03-28 23:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-28 0:28 What's in git.git Junio C Hamano
2006-03-28 1:15 ` [PATCH] Add ALL_LDFLAGS to the git target Jason Riedy
2006-03-28 1:25 ` Junio C Hamano
2006-03-28 3:11 ` Jason Riedy
2006-03-28 6:21 ` Junio C Hamano
2006-03-28 19:46 ` Jason Riedy
2006-03-28 22:48 ` Mark Wooding
2006-03-28 23:03 ` Linus Torvalds [this message]
2006-03-28 23:20 ` Junio C Hamano
2006-03-28 23:59 ` Jason Riedy
2006-03-29 0:01 ` Junio C Hamano
2006-03-28 23:21 ` Mark Wooding
2006-03-29 0:16 ` [PATCH] Support for pickaxe matching regular expressions Petr Baudis
2006-03-29 13:09 ` Petr Baudis
2006-03-29 11:42 ` [PATCH] Add ALL_LDFLAGS to the git target Johannes Schindelin
2006-03-28 2:05 ` Gitk strangeness Linus Torvalds
2006-03-28 2:12 ` Junio C Hamano
2006-03-28 2:31 ` Paul Mackerras
2006-03-28 2:52 ` Linus Torvalds
2006-03-28 2:54 ` Junio C Hamano
2006-03-28 4:31 ` Paul Mackerras
2006-03-28 5:38 ` Junio C Hamano
2006-03-28 6:18 ` Paul Mackerras
2006-03-28 7:52 ` Junio C Hamano
2006-03-28 22:51 ` Paul Mackerras
2006-03-29 0:50 ` Junio C Hamano
2006-03-29 6:41 ` Junio C Hamano
2006-03-30 20:57 ` Alex Riesen
2006-03-30 22:33 ` Paul Mackerras
2006-03-30 23:46 ` Paul Mackerras
2006-03-31 1:50 ` Junio C Hamano
2006-03-31 6:27 ` Alex Riesen
2006-03-28 2:57 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0603281500280.15714@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=mdw@distorted.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).