From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC 2/2] Make path-limiting be incremental when possible.
Date: Fri, 31 Mar 2006 11:44:51 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0603311139540.27203@g5.osdl.org> (raw)
In-Reply-To: <7v1wwjvwz9.fsf@assigned-by-dhcp.cox.net>
On Fri, 31 Mar 2006, Junio C Hamano wrote:
> Linus Torvalds <torvalds@osdl.org> writes:
>
> > This is an absolutely huge deal for anything like "git log -- <pathname>",
> > but also for some things that we don't do yet - like the "find where
> > things changed" logic I've described elsewhere, where we want to find the
> > previous revision that changed a file.
> >...
> > Btw, don't even bother testing this with the git archive. git itself is so
> > small that parsing the whole revision history for it takes about a second
> > even with path limiting.
>
> By the way, I forgot to praise you ;-).
>
> Even on a fast machine, the old one was not very useful, but
> this one is _instantaneous_. Very good job.
Indeed. It's why I'd really like this to be merged before 1.3.0 - it moves
a certain class of problems from "it works" to "it's actually usable".
Now, the _real_ usage I foresee (which just wasn't practical before) is
the interactive annotation thing - this won't help a _full_file_ annotate
(which usually needs to go back to the very first version of a file
anyway), but it should make it possible to play with an incremental one
(the "graphical git-whatchanged" kind).
But even just the "git log" difference makes it worth it.
Linus
prev parent reply other threads:[~2006-03-31 19:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-31 0:52 [PATCH/RFC 1/2] Move "--parent" parsing into generic revision.c library code Linus Torvalds
2006-03-31 1:05 ` [PATCH/RFC 2/2] Make path-limiting be incremental when possible Linus Torvalds
2006-03-31 6:05 ` Linus Torvalds
2006-03-31 6:45 ` Junio C Hamano
2006-03-31 19:39 ` Linus Torvalds
2006-03-31 20:35 ` Junio C Hamano
2006-03-31 20:50 ` Linus Torvalds
2006-03-31 6:16 ` Junio C Hamano
2006-03-31 6:42 ` Linus Torvalds
2006-03-31 7:02 ` Junio C Hamano
2006-04-02 0:35 ` Linus Torvalds
2006-04-02 3:11 ` Junio C Hamano
2006-04-02 3:17 ` [PATCH] revision: simplify argument parsing Junio C Hamano
[not found] ` <443063E2.1040904@lsrfire.ath.cx>
2006-04-03 4:22 ` Junio C Hamano
2006-04-02 3:17 ` [PATCH] revision: --max-age alone does not need limit_list() anymore Junio C Hamano
2006-03-31 8:28 ` [PATCH/RFC 2/2] Make path-limiting be incremental when possible Junio C Hamano
2006-03-31 19:44 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0603311139540.27203@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).