From: Davide Libenzi <davidel@xmailserver.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [RFH] xdiff shows trivially redundant diff.
Date: Sun, 2 Apr 2006 10:35:53 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0604021035130.30097@alien.or.mcafeemobile.com> (raw)
In-Reply-To: <7v4q1cmj7l.fsf@assigned-by-dhcp.cox.net>
On Sun, 2 Apr 2006, Junio C Hamano wrote:
> $ git diff-tree -p 52e8a6^2 52d8a6 -- git-fetch.sh
>
> shows a change that trivially is redundant, like this:
>
> diff --git a/git-fetch.sh b/git-fetch.sh
> index b4325d9..de4f011 100755
> --- a/git-fetch.sh
> +++ b/git-fetch.sh
> @@ -320,7 +320,7 @@ fetch_main () {
> ( : subshell because we muck with IFS
> IFS=" $LF"
> (
> - git-fetch-pack $exec $keep "$remo...
> + git-fetch-pack $exec $keep --thin...
> ) |
> while read sha1 remote_name
> do
> @@ -367,21 +367,26 @@ fetch_main "$reflist"
>
> # automated tag following
> case "$no_tags$tags" in
> -'')
> - taglist=$(IFS=" " &&
> - git-ls-remote $upload_pack --tags "$remote" |
> ...
> - done)
> +'')
> + case "$reflist" in
> + *:refs/*)
> ...
>
> Notice the first '-' and '+' lines of second hunk are identical?
>
> There is another interesting thing. This is running diff
> between 52e8a6^2 and 52d8a6 blobs, but if I change them slightly
> so that the first hunk is not different, then this anomaly
> disappears.
Could you send me the two files that creates the above diff?
- Davide
next prev parent reply other threads:[~2006-04-02 17:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-02 9:15 [RFH] xdiff shows trivially redundant diff Junio C Hamano
2006-04-02 17:35 ` Davide Libenzi [this message]
2006-04-02 21:02 ` Junio C Hamano
2006-04-02 21:16 ` Linus Torvalds
2006-04-02 22:18 ` Davide Libenzi
2006-04-02 22:14 ` Davide Libenzi
2006-04-03 0:52 ` Linus Torvalds
2006-04-03 3:26 ` Davide Libenzi
2006-04-03 4:19 ` Linus Torvalds
2006-04-03 4:30 ` Davide Libenzi
2006-04-03 7:33 ` Junio C Hamano
2006-04-03 19:33 ` Davide Libenzi
2006-04-03 19:42 ` Davide Libenzi
2006-04-03 20:01 ` Junio C Hamano
2006-04-03 22:50 ` Davide Libenzi
2006-04-03 23:29 ` Davide Libenzi
2006-04-04 1:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0604021035130.30097@alien.or.mcafeemobile.com \
--to=davidel@xmailserver.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).