git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFH] xdiff shows trivially redundant diff.
@ 2006-04-02  9:15 Junio C Hamano
  2006-04-02 17:35 ` Davide Libenzi
  0 siblings, 1 reply; 17+ messages in thread
From: Junio C Hamano @ 2006-04-02  9:15 UTC (permalink / raw)
  To: git; +Cc: Davide Libenzi, Linus Torvalds

$ git diff-tree -p 52e8a6^2 52d8a6 -- git-fetch.sh

shows a change that trivially is redundant, like this:

    diff --git a/git-fetch.sh b/git-fetch.sh
    index b4325d9..de4f011 100755
    --- a/git-fetch.sh
    +++ b/git-fetch.sh
    @@ -320,7 +320,7 @@ fetch_main () {
         ( : subshell because we muck with IFS
           IFS="    $LF"
           (
    -         git-fetch-pack $exec $keep "$remo...
    +         git-fetch-pack $exec $keep --thin...
           ) |
           while read sha1 remote_name
           do
    @@ -367,21 +367,26 @@ fetch_main "$reflist"

     # automated tag following
     case "$no_tags$tags" in
    -'')
    -       taglist=$(IFS=" " &&
    -       git-ls-remote $upload_pack --tags "$remote" |
    ...
    -       done)
    +'')
    +       case "$reflist" in
    +       *:refs/*)
    ...

Notice the first '-' and '+' lines of second hunk are identical?

There is another interesting thing.  This is running diff
between 52e8a6^2 and 52d8a6 blobs, but if I change them slightly
so that the first hunk is not different, then this anomaly
disappears.

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2006-04-04  1:55 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-02  9:15 [RFH] xdiff shows trivially redundant diff Junio C Hamano
2006-04-02 17:35 ` Davide Libenzi
2006-04-02 21:02   ` Junio C Hamano
2006-04-02 21:16     ` Linus Torvalds
2006-04-02 22:18       ` Davide Libenzi
2006-04-02 22:14     ` Davide Libenzi
2006-04-03  0:52       ` Linus Torvalds
2006-04-03  3:26         ` Davide Libenzi
2006-04-03  4:19           ` Linus Torvalds
2006-04-03  4:30             ` Davide Libenzi
2006-04-03  7:33               ` Junio C Hamano
2006-04-03 19:33                 ` Davide Libenzi
2006-04-03 19:42                   ` Davide Libenzi
2006-04-03 20:01                   ` Junio C Hamano
2006-04-03 22:50                     ` Davide Libenzi
2006-04-03 23:29     ` Davide Libenzi
2006-04-04  1:55       ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).