From: Nicolas Pitre <nico@cam.org>
To: Peter Eriksen <s022018@student.dtu.dk>
Cc: git@vger.kernel.org
Subject: Re: [RFH] Exploration of an alternative diff_delta() algorithm
Date: Sun, 09 Apr 2006 14:08:38 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0604091401560.2215@localhost.localdomain> (raw)
In-Reply-To: <20060409175316.GA21455@erlang.gbar.dtu.dk>
On Sun, 9 Apr 2006, Peter Eriksen wrote:
> On Sun, Apr 09, 2006 at 01:40:14PM -0400, Nicolas Pitre wrote:
> ...
> > It also has lots of compilation warnings.
>
> Hm, I don't get any warnings. Would you mind pasting them, so I
> can see what it's about?
gcc -o diff-delta.o -c -g -O2 -Wall -DSHA1_HEADER='<openssl/sha.h>' diff-delta.c
diff-delta.c: In function 'diff_delta':
diff-delta.c:123: warning: pointer targets in passing argument 1 of 'init_hash' differ in signedness
diff-delta.c:124: warning: pointer targets in passing argument 1 of 'init_hash' differ in signedness
diff-delta.c:170: warning: pointer targets in passing argument 1 of 'hash' differ in signedness
diff-delta.c:171: warning: pointer targets in passing argument 1 of 'hash' differ in signedness
diff-delta.c:203: warning: pointer targets in passing argument 1 of 'init_hash' differ in signedness
diff-delta.c:204: warning: pointer targets in passing argument 1 of 'init_hash' differ in signedness
Also you should avoid declaring new variables after code in the same
scope, like you do with version_offset for example. This is a feature
that many C compilers don't support.
Nicolas
prev parent reply other threads:[~2006-04-09 18:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-09 14:31 [RFH] Exploration of an alternative diff_delta() algorithm Peter Eriksen
2006-04-09 17:14 ` Nicolas Pitre
2006-04-09 17:34 ` Peter Eriksen
2006-04-09 17:45 ` Nicolas Pitre
2006-04-09 22:45 ` Peter Eriksen
2006-04-10 3:29 ` Nicolas Pitre
2006-04-09 17:40 ` Nicolas Pitre
2006-04-09 17:53 ` Peter Eriksen
2006-04-09 18:08 ` Nicolas Pitre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0604091401560.2215@localhost.localdomain \
--to=nico@cam.org \
--cc=git@vger.kernel.org \
--cc=s022018@student.dtu.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).