From: Linus Torvalds <torvalds@osdl.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: path limiting broken
Date: Sun, 16 Apr 2006 19:48:11 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0604161943360.3701@g5.osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0604170138470.824@wbgn013.biozentrum.uni-wuerzburg.de>
On Mon, 17 Apr 2006, Johannes Schindelin wrote:
>
> Since quite some time, I wanted to have a way to git-rev-list just the
> revs between commit1 and commit2, i.e. all commits which are ancestors of
> commit2, and which have commit1 as ancestor. With this, my task would have
> been more than simple.
Yes. However, it's not trivial.
In fact, what you want is not what you claim you want. To be useful in
general, you have to _also_ handle the case of "commit2" not beign a
strict ancestor of "commit1". So what you actually want to do is
- calculate the merge-head of cmit1 and cmit2 (and if there are multiple,
pick some "best" one).
- pick the shortest path from the merge-head to the cmit1 (and, with a
flag, also pick the path from merge-head to cmit2 - sometimes you want
to see the whole path from one to the other, sometimes you might want
to see just the path from the last common point).
I suspect it ends up being not _that_ different from calculating the
bisection point, but I haven't thought it through entirely.
Linus
next prev parent reply other threads:[~2006-04-17 2:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-16 12:26 path limiting broken Johannes Schindelin
2006-04-16 16:06 ` Linus Torvalds
2006-04-16 16:45 ` Johannes Schindelin
2006-04-16 17:07 ` Linus Torvalds
2006-04-16 17:27 ` path limiting broken (NOT) Johannes Schindelin
2006-04-16 17:39 ` path limiting broken Johannes Schindelin
2006-04-16 17:58 ` Linus Torvalds
2006-04-16 18:09 ` Johannes Schindelin
2006-04-16 18:27 ` Linus Torvalds
2006-04-16 23:49 ` Johannes Schindelin
2006-04-17 2:48 ` Linus Torvalds [this message]
2006-04-16 17:05 ` Johannes Schindelin
2006-04-16 17:51 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0604161943360.3701@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).