git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: Log message printout cleanups
Date: Tue, 18 Apr 2006 08:37:22 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0604180827040.3701@g5.osdl.org> (raw)
In-Reply-To: <7vd5ffig70.fsf@assigned-by-dhcp.cox.net>



On Mon, 17 Apr 2006, Junio C Hamano wrote:
> 
> I think this does what both of us want.  One thing I noticed is
> that log-tree-diff-flush does "---\n" under --patch-with-stat
> but not under --stat; I matched that here.

Looks very nice now. Thanks.

My only slight complaint is that I think it should be possible to do

	git log --cc --stat

to get both patches and stat, but that doesn't work. You have to write

	git log --cc --patch-with-stat

to get both ;/

But that's just a small (and unimportant) detail.

Here's another really small detail: with merges, there's two newlines 
between the diffstat and the diff. That bug doesn't show up with regular 
commits.

But this all looks very nice. I agree that "git log --stat" is a very nice 
way to look at the log, much better than "git-whatchanged". And the thing 
that has really fallen out of this all is how you can do

	git log --stat --full-diff drivers/pci/

which git-whatchanged historically didn't support (of course, now it 
does, but you're right, the new "git log" is so nice that I'm starting to 
teach myself not to use "git whatchanged" any more).

		Linus

  reply	other threads:[~2006-04-18 15:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-16 22:17 Fixes for option parsing Linus Torvalds
2006-04-17  0:29 ` Junio C Hamano
2006-04-17  2:42   ` Linus Torvalds
2006-04-17  3:03     ` Linus Torvalds
2006-04-17  3:36     ` Junio C Hamano
2006-04-17 14:51       ` Linus Torvalds
2006-04-17 18:59   ` Log message printout cleanups Linus Torvalds
2006-04-17 22:45     ` Junio C Hamano
2006-04-17 23:59       ` Linus Torvalds
2006-04-18  0:22         ` Junio C Hamano
2006-04-18  0:37           ` Junio C Hamano
2006-04-18  0:57             ` Linus Torvalds
2006-04-18  5:52               ` Junio C Hamano
2006-04-18 15:37                 ` Linus Torvalds [this message]
2006-04-18 16:06                   ` Linus Torvalds
2006-04-18 16:48                     ` Junio C Hamano
2006-04-18 18:33                     ` [PATCH] diff --stat: make sure to set recursive Junio C Hamano
2006-04-18  0:43           ` Log message printout cleanups Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0604180827040.3701@g5.osdl.org \
    --to=torvalds@osdl.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).