git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: git@vger.kernel.org
Subject: Re: Next problem: empty ident  <joern@limerick.(none)> not allowed
Date: Tue, 18 Apr 2006 13:47:23 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0604181341000.3701@g5.osdl.org> (raw)
In-Reply-To: <20060418202525.GD25688@wohnheim.fh-wedel.de>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1426 bytes --]



On Tue, 18 Apr 2006, Jörn Engel wrote:
> 
> And now I have some questions:
> 1. Why didn't the environment variables work?

They do. But they just described the _author_. Git wanted the _committer_ 
to be described too.

So if you had used GIT_COMMITTER_NAME/EMAIL, everything would have been 
fine.

Notice that if you don't give any author information, git will assume that 
the committer is the author, so if you give committer information, you 
don't actually need to give author information. It "knows" that the 
committer is you, and since you don't tell it otherwise, it will think 
that you're the author too.

So the committer is always the "default author".

But the reverse is _not_ true: even if you tell git who the author is, it 
will _not_ assume that the committer is the same one. It knows that the 
committer is you, but you didn't talk about yourself, you just talked 
about the author.

That non-symmetric behaviour does make a lot of sense, if you think about 
it a while. The author is _not_ the "default committer". 

Putting your name and email in the git config file solves the problem, 
because then git knows who the committer is (and by extension, the 
"default author").

> 2. Why is there a check for commit information when I pull from some
> tree?

Because you're going to create a merge commit. It wants to know who to 
attribute that merge to. Why the committer is, in other words.

		Linus

      parent reply	other threads:[~2006-04-18 20:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-18 20:25 Next problem: empty ident <joern@limerick.(none)> not allowed Jörn Engel
2006-04-18 20:37 ` Junio C Hamano
2006-04-18 20:40   ` Jörn Engel
2006-04-18 20:37 ` Junio C Hamano
2006-04-19  9:51   ` Petr Baudis
2006-04-18 20:47 ` Linus Torvalds [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0604181341000.3701@g5.osdl.org \
    --to=torvalds@osdl.org \
    --cc=git@vger.kernel.org \
    --cc=joern@wohnheim.fh-wedel.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).