git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>, Git Mailing List <git@vger.kernel.org>
Subject: Fix uninteresting tags in new revision parsing
Date: Tue, 18 Apr 2006 20:31:41 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0604182027460.3701@g5.osdl.org> (raw)


When I unified the revision argument parsing, I introduced a simple bug 
wrt tags that had been marked uninteresting. When it was preparing for the 
revision walk, it would mark all the parent commits of an uninteresting 
tag correctly uninteresting, but it would forget about the commit itself.

This means that when I just did my 2.6.17-rc2 release, and my scripts 
generated the log for "v2.6.17-rc1..v2.6.17-rc2", everything was fine, 
except the commit pointed to by 2.6.17-rc1 (which shouldn't have been 
there) was included. Even though it should obviously have been marked as 
being uninteresting.

Not a huge deal, and the fix is trivial.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---
diff --git a/revision.c b/revision.c
index dbd54da..113dd5a 100644
--- a/revision.c
+++ b/revision.c
@@ -152,6 +152,7 @@ static struct commit *handle_commit(stru
 		if (parse_commit(commit) < 0)
 			die("unable to parse commit %s", name);
 		if (flags & UNINTERESTING) {
+			commit->object.flags |= UNINTERESTING;
 			mark_parents_uninteresting(commit);
 			revs->limited = 1;
 		}

             reply	other threads:[~2006-04-19  3:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-19  3:31 Linus Torvalds [this message]
2006-04-19  4:36 ` Fix uninteresting tags in new revision parsing Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0604182027460.3701@g5.osdl.org \
    --to=torvalds@osdl.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).