git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Fix uninteresting tags in new revision parsing
@ 2006-04-19  3:31 Linus Torvalds
  2006-04-19  4:36 ` Junio C Hamano
  0 siblings, 1 reply; 2+ messages in thread
From: Linus Torvalds @ 2006-04-19  3:31 UTC (permalink / raw)
  To: Junio C Hamano, Git Mailing List


When I unified the revision argument parsing, I introduced a simple bug 
wrt tags that had been marked uninteresting. When it was preparing for the 
revision walk, it would mark all the parent commits of an uninteresting 
tag correctly uninteresting, but it would forget about the commit itself.

This means that when I just did my 2.6.17-rc2 release, and my scripts 
generated the log for "v2.6.17-rc1..v2.6.17-rc2", everything was fine, 
except the commit pointed to by 2.6.17-rc1 (which shouldn't have been 
there) was included. Even though it should obviously have been marked as 
being uninteresting.

Not a huge deal, and the fix is trivial.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---
diff --git a/revision.c b/revision.c
index dbd54da..113dd5a 100644
--- a/revision.c
+++ b/revision.c
@@ -152,6 +152,7 @@ static struct commit *handle_commit(stru
 		if (parse_commit(commit) < 0)
 			die("unable to parse commit %s", name);
 		if (flags & UNINTERESTING) {
+			commit->object.flags |= UNINTERESTING;
 			mark_parents_uninteresting(commit);
 			revs->limited = 1;
 		}

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: Fix uninteresting tags in new revision parsing
  2006-04-19  3:31 Fix uninteresting tags in new revision parsing Linus Torvalds
@ 2006-04-19  4:36 ` Junio C Hamano
  0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2006-04-19  4:36 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: git

Linus Torvalds <torvalds@osdl.org> writes:

> When I unified the revision argument parsing, I introduced a simple bug 
> wrt tags that had been marked uninteresting. When it was preparing for the 
> revision walk, it would mark all the parent commits of an uninteresting 
> tag correctly uninteresting, but it would forget about the commit itself.

Thanks.  Can't believe I missed it...

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-04-19  4:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-19  3:31 Fix uninteresting tags in new revision parsing Linus Torvalds
2006-04-19  4:36 ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).