git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fix pack-object buffer size
@ 2006-04-20 21:25 Nicolas Pitre
  0 siblings, 0 replies; only message in thread
From: Nicolas Pitre @ 2006-04-20 21:25 UTC (permalink / raw)
  To: git

The input line has 40 _chars_ of sha1 and no 20 _bytes_. It should also 
account for the space before the pathname, and the terminating \n and \0.

Signed-off-by: Nicolas Pitre <nico@cam.org>
---

I doubt anyone has ever used a repository with paths long enough to hit 
the limit, but better make it right nevertheless.

diff --git a/pack-objects.c b/pack-objects.c
index 09f4f2c..3c2767b 100644
--- a/pack-objects.c
+++ b/pack-objects.c
@@ -1231,7 +1231,7 @@ static void setup_progress_signal(void)
 int main(int argc, char **argv)
 {
 	SHA_CTX ctx;
-	char line[PATH_MAX + 20];
+	char line[40 + 1 + PATH_MAX + 2];
 	int window = 10, depth = 10, pack_to_stdout = 0;
 	struct object_entry **list;
 	int num_preferred_base = 0;

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2006-04-20 21:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-20 21:25 [PATCH] fix pack-object buffer size Nicolas Pitre

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).