From: Linus Torvalds <torvalds@osdl.org>
To: Bob Portmann <bportmann@yahoo.com>, Junio C Hamano <junkio@cox.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: git-log produces no output
Date: Fri, 21 Apr 2006 12:25:13 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0604211223561.3701@g5.osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0604211214560.3701@g5.osdl.org>
On Fri, 21 Apr 2006, Linus Torvalds wrote:
>
> This patch would have made things a lot more obvious.
Actually, scratch that one, and use this one instead. Much better, and
actually allows Bob's crazy PAGER environment variable to work, rather
than just reporting an error about it.
Linus
---
diff --git a/pager.c b/pager.c
index b063353..9a30939 100644
--- a/pager.c
+++ b/pager.c
@@ -8,6 +8,7 @@ #include "cache.h"
static void run_pager(const char *pager)
{
execlp(pager, pager, NULL);
+ execl("/bin/sh", "sh", "-c", pager, NULL);
}
void setup_pager(void)
@@ -47,5 +48,6 @@ void setup_pager(void)
setenv("LESS", "-S", 0);
run_pager(pager);
+ die("unable to execute pager '%s'", pager);
exit(255);
}
next prev parent reply other threads:[~2006-04-21 19:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 17:20 git-log produces no output Bob Portmann
2006-04-21 18:11 ` Linus Torvalds
2006-04-21 18:48 ` Bob Portmann
2006-04-21 18:58 ` Paolo Ciarrocchi
2006-04-21 19:13 ` Bob Portmann
2006-04-21 19:18 ` Linus Torvalds
2006-04-21 19:25 ` Linus Torvalds [this message]
2006-04-21 19:38 ` Bob Portmann
2006-04-21 20:05 ` Junio C Hamano
2006-04-21 20:25 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0604211223561.3701@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=bportmann@yahoo.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).