From: Nicolas Pitre <nico@cam.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC] reverse the pack-objects delta window logic
Date: Wed, 26 Apr 2006 13:48:13 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0604261341200.18520@localhost.localdomain> (raw)
In-Reply-To: <7vpsj4sxer.fsf@assigned-by-dhcp.cox.net>
On Tue, 25 Apr 2006, Junio C Hamano wrote:
> Nicolas Pitre <nico@cam.org> writes:
>
> > Note, this is a RFC particularly to Junio since the resulting pack is
> > larger than without the patch with git-repack -a -f. However using a
> > subsequent git-repack -a brings the pack size down to expected size. So
> > I'm not sure I've got everything right.
>
> I haven't tested it seriously yet, but there is nothing that
> looks obviously wrong that might cause the inflation problem,
> from the cursory look after applying the patch on top of your
> last round.
Never mind. I found a flaw in the determination of delta_limit when
reparenting a delta target. The immediate parent's delta_limit is
readjusted when its longest delta is moved to another base, but if that
parent was itself a delta then the delta_limit adjustment is not
propagated back up to the top. This means that some objects were
falsely credited with too high delta_limit.
And actually I'm not sure how to solve that without walking the tree
up to the top each time, which I want to avoid as much as possible.
Nicolas
next prev parent reply other threads:[~2006-04-26 17:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-26 3:37 [PATCH/RFC] reverse the pack-objects delta window logic Nicolas Pitre
2006-04-26 5:45 ` Junio C Hamano
2006-04-26 15:48 ` Nicolas Pitre
2006-04-26 17:48 ` Nicolas Pitre [this message]
2006-04-27 3:05 ` Nicolas Pitre
2006-04-27 3:58 ` [PATCH] use delta index data when finding best delta matches Nicolas Pitre
2006-04-28 1:08 ` Junio C Hamano
2006-04-28 1:56 ` Nicolas Pitre
2006-04-27 5:04 ` [PATCH/RFC] reverse the pack-objects delta window logic Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0604261341200.18520@localhost.localdomain \
--to=nico@cam.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).