From: Linus Torvalds <torvalds@osdl.org>
To: Alex Riesen <raa.lkml@gmail.com>, Junio C Hamano <junkio@cox.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: bug: git-repack -a -d produces broken pack on NFS
Date: Thu, 27 Apr 2006 15:18:22 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0604271515490.3701@g5.osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0604271500500.3701@g5.osdl.org>
On Thu, 27 Apr 2006, Linus Torvalds wrote:
>
> I wonder if the _pack-file_ itself might be ok, and the problem is an
> index file corruption.
Hmm. verify_pack() actually checks that the index file matches its own
SHA1 earlier, so the index file will have passed (my suggested patch is
still correct: the same way we check the index file internal integrity
first, we should also check the pack-file internal integrity before we
bother to cross-check them with each other).
Anyway, the index file SHA1 check means that it's unlikely that the index
file was corrupt. But it would be interesting to hear if the pack-file was
internally consistent or not.. (Something that git-pack-check didn't check
in your case, because it checked the pack-file against the index file data
first).
Linus
next prev parent reply other threads:[~2006-04-27 22:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-27 21:32 bug: git-repack -a -d produces broken pack on NFS Alex Riesen
2006-04-27 22:11 ` Linus Torvalds
2006-04-27 22:17 ` Junio C Hamano
2006-04-27 22:29 ` Linus Torvalds
2006-04-27 22:44 ` Junio C Hamano
2006-04-27 22:18 ` Linus Torvalds [this message]
2006-04-28 22:27 ` Alex Riesen
2006-04-28 23:18 ` Linus Torvalds
2006-04-27 23:54 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0604271515490.3701@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).