git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Paul Mackerras <paulus@samba.org>
Cc: git@vger.kernel.org
Subject: Re: gitk highlight feature
Date: Sat, 20 May 2006 09:42:30 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0605200934240.10823@g5.osdl.org> (raw)
In-Reply-To: <17518.24000.952384.563448@cargo.ozlabs.ibm.com>



On Sat, 20 May 2006, Paul Mackerras wrote:
> 
> I just pushed some changes to the "new" branch of the gitk.git
> repository which change the way we do highlighting.  There is now a
> row of controls across the middle of the window, just below the row
> containing the sha1 ID, "Find" button, etc., which controls the
> highlighting.

Ok, this is much nicer, I think this ends up being much closer to what I 
really wanted, even if I didn't know quite how I wanted it.

I think the "Find" field should highlight things too. Right now there's no 
way to get highlighting for somebody having signed-off on a patch, for 
example, even though you can _search_ for it.

Also, right now it says "Author/committer", but it actually only triggers 
on author. Which may be the right thing to do (it's certainly what I'd 
normally want to see), but it doesn't match the description. 

		Linus

  reply	other threads:[~2006-05-20 16:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-02 23:44 gitk highlight feature Paul Mackerras
2006-05-02 23:48 ` Junio C Hamano
2006-05-03  0:17   ` Paul Mackerras
2006-05-03  0:07 ` Linus Torvalds
2006-05-03  0:23   ` Linus Torvalds
2006-05-03  2:55     ` Paul Mackerras
2006-05-03 16:57       ` Linus Torvalds
2006-05-03 23:08         ` Paul Mackerras
2006-05-03 23:25           ` Linus Torvalds
2006-05-20  0:07         ` Paul Mackerras
2006-05-20 16:42           ` Linus Torvalds [this message]
2006-05-21  0:40             ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0605200934240.10823@g5.osdl.org \
    --to=torvalds@osdl.org \
    --cc=git@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).