From: Linus Torvalds <torvalds@osdl.org>
To: Martin Langhoff <martin@catalyst.net.nz>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <junkio@cox.net>,
Johannes.Schindelin@gmx.de, spyderous@gentoo.org,
smurf@smurf.noris.de
Subject: Re: [PATCH] cvsimport: introduce -L<imit> option to workaround memory leaks
Date: Mon, 22 May 2006 19:28:37 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0605221926270.3697@g5.osdl.org> (raw)
In-Reply-To: <11482978883713-git-send-email-martin@catalyst.net.nz>
This stupid patch on top of yours seems to make git happier. It's
disgusting, I know, but it just repacks things every kilo-commit.
I actually think that I found a real ext3 performance bug from trying to
determine why git sometimes slows down ridiculously when the tree has been
allowed to go too long without a repack.
Linus
---
diff --git a/git-cvsimport.perl b/git-cvsimport.perl
index fb56278..c141f5e 100755
--- a/git-cvsimport.perl
+++ b/git-cvsimport.perl
@@ -853,10 +853,14 @@ # VERSION:1.96->1.96.2.1
} elsif($state == 9 and /^\s*$/) {
$state = 10;
} elsif(($state == 9 or $state == 10) and /^-+$/) {
- if ($opt_L && $commitcount++ >= $opt_L) {
+ $commitcount++;
+ if ($opt_L && $commitcount > $opt_L) {
last;
}
commit();
+ if (($commitcount & 1023) == 0) {
+ system("git repack -a -d");
+ }
$state = 1;
} elsif($state == 11 and /^-+$/) {
$state = 1;
next prev parent reply other threads:[~2006-05-23 2:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-22 11:38 [PATCH] cvsimport: introduce -L<imit> option to workaround memory leaks Martin Langhoff
2006-05-23 2:28 ` Linus Torvalds [this message]
2006-05-23 3:15 ` Martin Langhoff (CatalystIT)
2006-05-23 15:36 ` Theodore Tso
2006-05-23 16:05 ` Linus Torvalds
2006-05-23 16:25 ` Linus Torvalds
2006-05-26 0:42 ` Martin Langhoff
2006-05-26 5:20 ` Linus Torvalds
2006-05-26 5:29 ` Jakub Narebski
2006-05-26 6:02 ` Martin Langhoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0605221926270.3697@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=martin@catalyst.net.nz \
--cc=smurf@smurf.noris.de \
--cc=spyderous@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).