From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Catalin Marinas <catalin.marinas@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Add a test-case for git-apply trying to add an ending line
Date: Tue, 23 May 2006 19:17:44 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0605231916210.5623@g5.osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0605231905470.5623@g5.osdl.org>
On Tue, 23 May 2006, Linus Torvalds wrote:
>
> + /*
> + * If we don't have any trailing data in the patch,
> + * we want to match the final ending '\0' byte in
> + * the file too..
> + */
Btw, ignore the comment. I was thinking of doing the matching differently
(just make the source buffer include a '\0' at the end, and forcing that
to match), but once I actually wrote it, it ended up being much easier to
just check the offset/size difference.
So that "final ending '\0' byte in the file" part of the comment is just
nonsense.
Linus
next prev parent reply other threads:[~2006-05-24 2:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-23 21:48 [PATCH] Add a test-case for git-apply trying to add an ending line Catalin Marinas
2006-05-24 0:31 ` Junio C Hamano
2006-05-24 1:09 ` Junio C Hamano
2006-05-24 1:09 ` Junio C Hamano
2006-05-24 2:08 ` Linus Torvalds
2006-05-24 2:17 ` Linus Torvalds [this message]
2006-05-24 4:59 ` Junio C Hamano
2006-05-24 13:32 ` Catalin Marinas
2006-05-24 14:49 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0605231916210.5623@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).