From: Linus Torvalds <torvalds@osdl.org>
To: Anton Blanchard <anton@samba.org>
Cc: Git Mailing List <git@vger.kernel.org>, Junio C Hamano <junkio@cox.net>
Subject: Re: git clone takes ages on a slow link
Date: Sun, 4 Jun 2006 10:48:31 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0606041046340.5498@g5.osdl.org> (raw)
In-Reply-To: <20060604010145.GC986@krispykreme>
On Sun, 4 Jun 2006, Anton Blanchard wrote:
>
> I think the ticker is over anxious.
It is indeed. It's _meant_ to only tick once a second or when the
percentage changes, but I think it forgot to clear the "once a second
happened" flag, so instead of updates the percentage output for every
file it checks out after the first second has passed.
So something like this should help... Can you verify?
Linus
---
diff --git a/builtin-read-tree.c b/builtin-read-tree.c
index 716f792..80c9320 100644
--- a/builtin-read-tree.c
+++ b/builtin-read-tree.c
@@ -336,6 +336,7 @@ static void check_updates(struct cache_e
fprintf(stderr, "%4u%% (%u/%u) done\r",
percent, cnt, total);
last_percent = percent;
+ progress_update = 0;
}
}
}
next prev parent reply other threads:[~2006-06-04 17:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-04 1:01 git clone takes ages on a slow link Anton Blanchard
2006-06-04 17:48 ` Linus Torvalds [this message]
2006-06-04 22:29 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0606041046340.5498@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=anton@samba.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).