* [PATCH] builtin-grep: pass ignore case option to external grep
@ 2006-06-06 23:15 Robert Fitzsimons
2006-06-06 23:27 ` Linus Torvalds
0 siblings, 1 reply; 2+ messages in thread
From: Robert Fitzsimons @ 2006-06-06 23:15 UTC (permalink / raw)
To: git
Don't just read the --ignore-case/-i option, pass the flag on to the
external grep program.
Signed-off-by: Robert Fitzsimons <robfitz@273k.net>
---
builtin-grep.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/builtin-grep.c b/builtin-grep.c
index acc4eea..5fac570 100644
--- a/builtin-grep.c
+++ b/builtin-grep.c
@@ -459,6 +459,8 @@ static int external_grep(struct grep_opt
push_arg("-n");
if (opt->regflags & REG_EXTENDED)
push_arg("-E");
+ if (opt->regflags & REG_ICASE)
+ push_arg("-i");
if (opt->word_regexp)
push_arg("-w");
if (opt->name_only)
--
1.3.3.g16a4-dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] builtin-grep: pass ignore case option to external grep
2006-06-06 23:15 [PATCH] builtin-grep: pass ignore case option to external grep Robert Fitzsimons
@ 2006-06-06 23:27 ` Linus Torvalds
0 siblings, 0 replies; 2+ messages in thread
From: Linus Torvalds @ 2006-06-06 23:27 UTC (permalink / raw)
To: Robert Fitzsimons; +Cc: git
On Tue, 6 Jun 2006, Robert Fitzsimons wrote:
>
> Don't just read the --ignore-case/-i option, pass the flag on to the
> external grep program.
Oops. How did we miss that one ;)
Embarrassing.
Linus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-06-06 23:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-06 23:15 [PATCH] builtin-grep: pass ignore case option to external grep Robert Fitzsimons
2006-06-06 23:27 ` Linus Torvalds
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).