From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>,
Git Mailing List <git@vger.kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: git-applymbox broken?
Date: Sun, 11 Jun 2006 15:40:24 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0606111535310.5498@g5.osdl.org> (raw)
It looks like something has broken git-applymbox lately.
The "From: authorname" lines are no longer removed from the message, and
are duplicated in the commit log. This has resulted in several recent
kernel commits looking like this:
commit c0bbbc73d58f1b774cd987b5687a478a027f137c
Author: Christoph Lameter <clameter@sgi.com>
Date: Sun Jun 11 15:22:26 2006 -0700
[PATCH] typo in vmscan.c
From: Christoph Lameter <clameter@sgi.com>
Looks like a comma was left from the conversion from a struct to an
assignment.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
where that "From:" in the body is totally wrong. I just didn't notice,
until now. Arrr!
I _suspect_ that this is the work by Eric Biederman, ie part of the
patches that do "Allow in body headers beyond the in body header
prefix." and "Refactor commit messge handling."
Eric? Can you please fix this up? Lines from the body of the email that
have been used to set authorship should _not_ also show up in the commit
message.
Linus
next reply other threads:[~2006-06-11 22:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-11 22:40 Linus Torvalds [this message]
2006-06-11 23:33 ` git-applymbox broken? Eric W. Biederman
2006-06-12 0:37 ` Linus Torvalds
2006-06-12 7:35 ` Eric W. Biederman
2006-06-12 18:45 ` [PATCH] Ignore blank lines among this inbody headers Eric W. Biederman
2006-06-12 19:29 ` Eric W. Biederman
2006-06-12 18:58 ` git-applymbox broken? Eric W. Biederman
2006-06-12 19:10 ` Linus Torvalds
2006-06-12 19:48 ` [PATCH] Don't parse any headers in the real body of an email message Eric W. Biederman
2006-06-12 20:10 ` git-applymbox broken? Eric W. Biederman
2006-06-12 22:43 ` Johannes Schindelin
2006-06-12 23:54 ` Randy.Dunlap
2006-06-13 3:41 ` Ryan Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0606111535310.5498@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=ebiederm@xmission.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).