From: Linus Torvalds <torvalds@osdl.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Junio C Hamano <junkio@cox.net>, Git Mailing List <git@vger.kernel.org>
Subject: Re: git-applymbox broken?
Date: Sun, 11 Jun 2006 17:37:47 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0606111735440.5498@g5.osdl.org> (raw)
In-Reply-To: <m1wtbn468o.fsf@ebiederm.dsl.xmission.com>
On Sun, 11 Jun 2006, Eric W. Biederman wrote:
>
> This doesn't look like the From: header was in the middle of the
> message until it was imported into git so it is probably a small
> logic error that is easily corrected. But I need to see what
> we are parsing so I can understand what is happening.
No, it's at the top of the body, although there might have been an empty
line or two (ie whitespace only) before it.
> Even if the header lines are in the middle of the body?
What do you mean by "middle"?
No, it should only look at From: and Subject: lines if they are at the
very top, with no other non-whitespace lines above them. But when it looks
at them and uses the data from them, it should then remove them from the
body - they are "conceptually" just extended header lines that just
happened to technically (from an rfc822 standpoint) be in the body of the
email.
Linus
next prev parent reply other threads:[~2006-06-12 0:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-11 22:40 git-applymbox broken? Linus Torvalds
2006-06-11 23:33 ` Eric W. Biederman
2006-06-12 0:37 ` Linus Torvalds [this message]
2006-06-12 7:35 ` Eric W. Biederman
2006-06-12 18:45 ` [PATCH] Ignore blank lines among this inbody headers Eric W. Biederman
2006-06-12 19:29 ` Eric W. Biederman
2006-06-12 18:58 ` git-applymbox broken? Eric W. Biederman
2006-06-12 19:10 ` Linus Torvalds
2006-06-12 19:48 ` [PATCH] Don't parse any headers in the real body of an email message Eric W. Biederman
2006-06-12 20:10 ` git-applymbox broken? Eric W. Biederman
2006-06-12 22:43 ` Johannes Schindelin
2006-06-12 23:54 ` Randy.Dunlap
2006-06-13 3:41 ` Ryan Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0606111735440.5498@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=ebiederm@xmission.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).