git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Fredrik Kuivinen <freku045@student.liu.se>,
	Florian Forster <octo@verplant.org>,
	git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Adding a `blame' interface.
Date: Mon, 12 Jun 2006 16:21:44 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0606121619510.5498@g5.osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0606130053400.25682@wbgn013.biozentrum.uni-wuerzburg.de>



On Tue, 13 Jun 2006, Johannes Schindelin wrote:
> > 
> > The war _I_d like to see is the GUI thing which does the "show when this 
> > section changed last" by following the history down only so far that the 
> > selected section shows up in the diff against the most current thing.
> 
> But this is just the next step! Nothing prevents you -- once everybody 
> agrees that blame/annotate does the right thing -- to restrict the lines 
> of interest. And AFAICT both blame and annotate are good at stopping when 
> all lines are accounted for.

You misunderstand. It's not "all", it's "any" (in fact, it would be even 
better if it would be on a byte-range basis, not on a line-based diff 
basis).

And it needs the GUI to make it useful, because nobody in their right mind 
will say "git showchange fs/inode.c 77-89" (and then do it iteratively if 
the first one wasn't actually the interesting case).

		Linus

  reply	other threads:[~2006-06-12 23:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-11 15:45 [PATCH] gitweb: Adding a `blame' interface Florian Forster
2006-06-11 22:02 ` Martin Langhoff
2006-06-12  8:24   ` Florian Forster
2006-06-12  8:31     ` [PATCH] gitweb: Make the availability of the `blame' interface in gitweb configurable Florian Forster
2006-06-12  8:34     ` [PATCH] gitweb: Adding a `blame' interface Martin Langhoff
2006-06-12  8:40       ` Shawn Pearce
2006-06-12  9:08         ` Johannes Schindelin
2006-06-12  9:19           ` Shawn Pearce
2006-06-12 18:11       ` gitweb: Config file support (was: Adding a `blame' interface.) Florian Forster
2006-06-12 14:59     ` [PATCH] gitweb: Adding a `blame' interface Linus Torvalds
2006-06-12 17:57       ` [PATCH] gitweb: Supporting caches (was: Adding a `blame' interface.) Florian Forster
2006-06-12 21:29     ` [PATCH] gitweb: Adding a `blame' interface Jon Loeliger
2006-06-14 20:27   ` Junio C Hamano
2006-06-12 21:38 ` Fredrik Kuivinen
2006-06-12 22:42   ` Johannes Schindelin
2006-06-12 22:49     ` Linus Torvalds
2006-06-12 22:55       ` Johannes Schindelin
2006-06-12 23:21         ` Linus Torvalds [this message]
2006-06-15 19:46       ` Marco Costalba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0606121619510.5498@g5.osdl.org \
    --to=torvalds@osdl.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=freku045@student.liu.se \
    --cc=git@vger.kernel.org \
    --cc=octo@verplant.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).