From: Linus Torvalds <torvalds@osdl.org>
To: Keith Packard <keithp@keithp.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Repacking many disconnected blobs
Date: Wed, 14 Jun 2006 11:52:21 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0606141146310.5498@g5.osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0606141113130.5498@g5.osdl.org>
On Wed, 14 Jun 2006, Linus Torvalds wrote:
>
> You don't _need_ to shuffle. As mentioned, it will only affect the
> location of the data in the pack-file, which in turn will mostly matter
> as an IO pattern thing, not anything really fundamental. If the pack-file
> ends up caching well, the IO patterns obviously will never matter.
Actually, thinking about it more, the way you do things, shuffling
probably won't even help.
Why? Because you'll obviously have multiple files, and even if each file
were to be sorted "correctly", the access patterns from any global
standpoint won't really matter, becase you'd probably bounce back and
forth in the pack-file anyway.
So if anything, I would say
- just dump them into the packfile in whatever order is most convenient
- if you know that later phases will go through the objects and actually
use them (as opposed to just building trees out of their SHA1 values)
in some particular order, _that_ might be the ordering to use.
- in many ways, getting good delta chains is _much_ more important, since
"git repack -a -d" will re-use good deltas from a previous pack, but
will _not_ care about any ordering in the old pack. As well as
obviously improving the size of the temporary pack-files anyway.
I'll pontificate more if I can think of any other cases that might matter.
Linus
next prev parent reply other threads:[~2006-06-14 18:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-14 7:17 Repacking many disconnected blobs Keith Packard
2006-06-14 7:29 ` Shawn Pearce
2006-06-14 9:07 ` Johannes Schindelin
2006-06-14 12:33 ` Junio C Hamano
2006-06-14 9:37 ` Sergey Vlasov
2006-06-14 15:53 ` Linus Torvalds
2006-06-14 17:55 ` Keith Packard
2006-06-14 18:18 ` Linus Torvalds
2006-06-14 18:52 ` Linus Torvalds [this message]
2006-06-14 18:59 ` Keith Packard
2006-06-14 19:18 ` Linus Torvalds
2006-06-14 19:25 ` Nicolas Pitre
2006-06-14 21:05 ` Keith Packard
2006-06-14 21:17 ` Linus Torvalds
2006-06-14 21:20 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0606141146310.5498@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).