From: Linus Torvalds <torvalds@osdl.org>
To: Paul Mackerras <paulus@samba.org>
Cc: Martin Langhoff <martin.langhoff@gmail.com>,
Nicolas Pitre <nico@cam.org>, Jon Smirl <jonsmirl@gmail.com>,
git <git@vger.kernel.org>
Subject: Re: [PATCH] Fix PPC SHA1 routine for large input buffers
Date: Sun, 18 Jun 2006 22:02:55 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0606182145370.5498@g5.osdl.org> (raw)
In-Reply-To: <17557.57564.267469.561683@cargo.ozlabs.ibm.com>
On Mon, 19 Jun 2006, Paul Mackerras wrote:
>
> The PPC SHA1 routine had an overflow which meant that it gave
> incorrect results for input buffers >= 512MB. This fixes it by
> ensuring that the update of the total length in bits is done using
> 64-bit arithmetic.
>
> Signed-off-by: Paul Mackerras <paulus@samba.org>
Acked-by: Linus Torvalds <torvalds@osdl.org>
This fixes git-fsck-objects for me on the mozilla archive, no more
complaints about bad SHA1's.
And yeah, now it's taking me 14 minutes too, so the 7-minute fsck was just
because it didn't actually check the SHA1 of the large pack fully.
(Which is actually good news - half of the time is literally checking the
pack integrity. That implies that the individual object integrity isn't as
dominating as I thought it would be, and that things like hw-accelerated
SHA1 engines will help with fsck. I'd not be surprised to see things like
that in a couple of years).
Linus
next prev parent reply other threads:[~2006-06-19 5:03 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-09 2:17 Figured out how to get Mozilla into git Jon Smirl
2006-06-09 2:56 ` Nicolas Pitre
2006-06-09 3:06 ` Martin Langhoff
2006-06-09 3:28 ` Jon Smirl
2006-06-09 7:17 ` Jakub Narebski
2006-06-09 15:01 ` Linus Torvalds
2006-06-09 16:11 ` Nicolas Pitre
2006-06-09 16:30 ` Linus Torvalds
2006-06-09 17:38 ` Nicolas Pitre
2006-06-09 17:49 ` Linus Torvalds
2006-06-09 17:10 ` Jakub Narebski
2006-06-09 18:13 ` Jon Smirl
2006-06-09 19:00 ` Linus Torvalds
2006-06-09 20:17 ` Jon Smirl
2006-06-09 20:40 ` Linus Torvalds
2006-06-09 20:56 ` Jon Smirl
2006-06-09 21:57 ` Linus Torvalds
2006-06-09 22:17 ` Linus Torvalds
2006-06-09 23:16 ` Greg KH
2006-06-09 23:37 ` Martin Langhoff
2006-06-09 23:43 ` Linus Torvalds
2006-06-10 0:00 ` Jon Smirl
2006-06-10 0:11 ` Linus Torvalds
2006-06-10 0:16 ` Jon Smirl
2006-06-10 0:45 ` Jon Smirl
2006-06-09 20:44 ` Jakub Narebski
2006-06-09 21:05 ` Nicolas Pitre
2006-06-09 21:46 ` Jon Smirl
2006-06-10 1:23 ` Martin Langhoff
2006-06-10 1:14 ` Martin Langhoff
2006-06-10 1:33 ` Linus Torvalds
2006-06-10 1:43 ` Linus Torvalds
2006-06-10 1:48 ` Jon Smirl
2006-06-10 1:59 ` Linus Torvalds
2006-06-10 2:21 ` Jon Smirl
2006-06-10 2:34 ` Carl Worth
2006-06-10 3:08 ` Linus Torvalds
2006-06-10 8:21 ` Jakub Narebski
2006-06-10 9:00 ` Junio C Hamano
2006-06-10 8:36 ` Rogan Dawes
2006-06-10 9:08 ` Junio C Hamano
2006-06-10 14:47 ` Rogan Dawes
2006-06-10 14:58 ` Jakub Narebski
2006-06-10 15:14 ` Nicolas Pitre
2006-06-10 17:53 ` Linus Torvalds
2006-06-10 18:02 ` Jon Smirl
2006-06-10 18:36 ` Rogan Dawes
2006-06-10 3:01 ` Linus Torvalds
2006-06-10 2:30 ` Jon Smirl
2006-06-10 3:41 ` Martin Langhoff
2006-06-10 3:55 ` Junio C Hamano
2006-06-10 4:02 ` Linus Torvalds
2006-06-10 4:11 ` Linus Torvalds
2006-06-10 6:02 ` Jon Smirl
2006-06-10 6:15 ` Junio C Hamano
2006-06-10 15:44 ` Jon Smirl
2006-06-10 16:15 ` Timo Hirvonen
2006-06-10 18:37 ` Petr Baudis
2006-06-10 18:55 ` Lars Johannsen
2006-06-11 22:00 ` Nicolas Pitre
2006-06-18 19:26 ` Linus Torvalds
2006-06-18 21:40 ` Martin Langhoff
2006-06-18 22:36 ` Linus Torvalds
2006-06-18 22:51 ` Broken PPC sha1.. (Re: Figured out how to get Mozilla into git) Linus Torvalds
2006-06-18 23:25 ` [PATCH] Fix PPC SHA1 routine for large input buffers Paul Mackerras
2006-06-19 5:02 ` Linus Torvalds [this message]
2006-06-09 3:12 ` Figured out how to get Mozilla into git Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0606182145370.5498@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=jonsmirl@gmail.com \
--cc=martin.langhoff@gmail.com \
--cc=nico@cam.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).