From: Nicolas Pitre <nico@cam.org>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: wrong check condition in patch-delta.c?
Date: Tue, 20 Jun 2006 08:28:01 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0606200827120.3377@localhost.localdomain> (raw)
In-Reply-To: <fcaeb9bf0606192332j5b2ee4b9ycf2c63c7b1820204@mail.gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 418 bytes --]
On Tue, 20 Jun 2006, Nguyn Thái Ngc Duy wrote:
> Hi,
> While inspecting patch-delta.c, I encounter this:
> if (cp_off + cp_size < cp_size ||
> cp_off + cp_size > src_size ||
> cp_size > size)
> goto bad;
> "cp_off + cp_size < cp_size" doesn't make sense to me. Is it on purpose?
Yes, it absolutely is.
Nicolas
prev parent reply other threads:[~2006-06-20 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-20 6:32 wrong check condition in patch-delta.c? Nguyễn Thái Ngọc Duy
2006-06-20 7:21 ` Marco Roeland
2006-06-20 12:28 ` Nicolas Pitre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0606200827120.3377@localhost.localdomain \
--to=nico@cam.org \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).