From: Linus Torvalds <torvalds@osdl.org>
To: Martin Langhoff <martin@catalyst.net.nz>
Cc: git@vger.kernel.org, junkio@cox.net
Subject: Re: [RFC] git-fetch - repack in the background after fetching
Date: Sat, 24 Jun 2006 20:53:16 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0606242049500.3747@g5.osdl.org> (raw)
In-Reply-To: <11511486003924-git-send-email-martin@catalyst.net.nz>
On Sat, 24 Jun 2006, Martin Langhoff wrote:
>
> Check whether we have a large set of unpacked objects and repack
> after the fetch, but don't for the user to wait for us. Conditional
> on core.autorepack =! no.
I don't think this is safe.
It's also done stupidly.
Instead of askign how many unpacked objects we have with the (expensive)
git-rev-list, why not just do
ls "$GIT_DIR/objects/00" | wc -l
which is pretty much guaranteed to be faster and easier.
However, the more worrisome thing about background repacking is that while
it should be safe against normal users, if you have two _repacks_ at the
same time, they can decide to remove each others packs. Yeah, yeah, that's
pretty damn unlikely, but hey, "pretty damn unlikely" is not "impossible".
Also, I think you'd want to repack with "-l", in case the thing is set up
with an alternate object directory.
Linus
next prev parent reply other threads:[~2006-06-25 3:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-24 11:30 [RFC] git-fetch - repack in the background after fetching Martin Langhoff
2006-06-25 3:12 ` Junio C Hamano
2006-06-25 10:10 ` [PATCH] Repack should try to prevent itself from running twice, concurrently Ryan Anderson
2006-06-25 10:17 ` Johannes Schindelin
2006-06-25 3:53 ` Linus Torvalds [this message]
2006-06-25 9:25 ` [RFC] git-fetch - repack in the background after fetching Johannes Schindelin
2006-06-25 17:29 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2006-06-25 17:53 linux
2006-05-30 4:42 Martin Langhoff
2006-05-30 4:51 ` Linus Torvalds
2006-05-30 5:14 ` Martin Langhoff
2006-05-30 6:37 ` Daniel Barkalow
2006-05-30 14:53 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0606242049500.3747@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=martin@catalyst.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).