From: Linus Torvalds <torvalds@osdl.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Alex Riesen <raa.lkml@gmail.com>,
git@vger.kernel.org, Junio C Hamano <junkio@cox.net>,
Fredrik Kuivinen <freku045@student.liu.se>
Subject: Re: [PATCH] move get_merge_bases() to core lib; use it in merge-recursive
Date: Thu, 29 Jun 2006 11:26:23 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0606291123360.12404@g5.osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0606291814200.29667@wbgn013.biozentrum.uni-wuerzburg.de>
On Thu, 29 Jun 2006, Johannes Schindelin wrote:
>
> My point being: it makes no sense to split off get_merge_bases() if nobody
> uses it except for git-merge-base.
I disagree. Your get_merge_bases() function is another small step in
cleanup and libification, so I think it's perfectly valid regardless of
whether somebody uses it yet.
A lot of the libification effort ends up being preparatory, because often
you need to get past a hump of libifying a _lot_ in order to actually use
something in a library.
So at first, the only user is usually the old separate program. So you
libify get_merge_bases, and initially the only user is git-merge-base,
which could now be made a built-in, since the bulk of its code is going to
be linked in regardless..
Linus
next prev parent reply other threads:[~2006-06-29 18:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-27 15:48 CFT: merge-recursive in C (updated) Alex Riesen
2006-06-27 16:42 ` Johannes Schindelin
2006-06-27 22:32 ` Alex Riesen
2006-06-28 9:34 ` Alex Riesen
2006-06-28 10:04 ` Johannes Schindelin
2006-06-28 11:35 ` Alex Riesen
2006-06-28 12:55 ` Johannes Schindelin
2006-06-28 14:27 ` Alex Riesen
2006-06-28 15:09 ` Johannes Schindelin
2006-06-29 0:25 ` Alex Riesen
2006-06-29 2:41 ` Junio C Hamano
2006-06-29 8:43 ` Alex Riesen
2006-06-29 18:40 ` Johannes Schindelin
2006-06-29 23:28 ` Alex Riesen
2006-06-29 13:16 ` Johannes Schindelin
2006-06-29 13:16 ` [PATCH 1/2] refactor merge_bases() as preparation to libify merge-base Johannes Schindelin
2006-06-29 13:17 ` [PATCH] move get_merge_bases() to core lib; use it in merge-recursive Johannes Schindelin
2006-06-29 13:21 ` Johannes Schindelin
2006-06-29 14:12 ` Alex Riesen
2006-06-29 16:14 ` Johannes Schindelin
2006-06-29 14:13 ` Alex Riesen
2006-06-29 14:14 ` Alex Riesen
2006-06-29 16:14 ` Johannes Schindelin
2006-06-29 18:26 ` Linus Torvalds [this message]
2006-06-29 18:39 ` Junio C Hamano
2006-06-29 19:06 ` Johannes Schindelin
2006-06-29 20:58 ` Junio C Hamano
2006-06-30 0:27 ` Alex Riesen
2006-06-27 18:22 ` CFT: merge-recursive in C (updated) Linus Torvalds
2006-06-27 18:45 ` Johannes Schindelin
2006-06-27 19:10 ` Linus Torvalds
2006-06-27 22:36 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0606291123360.12404@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=freku045@student.liu.se \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).