From: Nicolas Pitre <nico@cam.org>
To: Shawn Pearce <spearce@spearce.org>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] Verify we know how to read a pack before trying to using it.
Date: Mon, 21 Aug 2006 11:51:55 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0608211148120.3851@localhost.localdomain> (raw)
In-Reply-To: <20060821071002.GA26029@spearce.org>
On Mon, 21 Aug 2006, Shawn Pearce wrote:
> If the pack format were to ever change or be extended in the future
> there is no assurance that just because the pack file lives in
> objects/pack and doesn't end in .idx that we can read and decompress
> its contents properly.
>
> If we encounter what we think is a pack file and it isn't or we don't
> recognize its version then die and suggest to the user that they
> upgrade to a newer version of GIT which can handle that pack file.
There are already 3 other places where the pack header and version are
validated: see git-grep pack_version_ok *.c output. Maybe it would be
best to abstract those tests all in one place.
Nicolas
prev parent reply other threads:[~2006-08-21 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-21 7:10 [PATCH] Verify we know how to read a pack before trying to using it Shawn Pearce
2006-08-21 8:00 ` Junio C Hamano
2006-08-21 15:51 ` Nicolas Pitre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0608211148120.3851@localhost.localdomain \
--to=nico@cam.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).