git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Petr Baudis <pasky@suse.cz>
Cc: Junio C Hamano <junkio@cox.net>, Git Mailing List <git@vger.kernel.org>
Subject: Re: Enable the packed refs file format
Date: Tue, 19 Sep 2006 14:09:57 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0609191407340.4388@g5.osdl.org> (raw)
In-Reply-To: <20060919205554.GA8259@pasky.or.cz>



On Tue, 19 Sep 2006, Petr Baudis wrote:

> Dear diary, on Thu, Sep 14, 2006 at 07:14:47PM CEST, I got a letter
> where Linus Torvalds <torvalds@osdl.org> said that...
> > +	ref_file = git_path(ref);
> 
> You slip...
> You fall...
> *BLAMMMM!!!*

Gaah. Yes. I fixed one such mistake already.

Too bad that we can't get gcc to warn on these things. We do mark it as 
"format(printf)", but I don't know of any way to tell gcc that it _has_ to 
have that initial constant string.

		Linus

  reply	other threads:[~2006-09-19 21:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-14 17:14 Enable the packed refs file format Linus Torvalds
2006-09-19 20:55 ` Petr Baudis
2006-09-19 21:09   ` Linus Torvalds [this message]
2006-09-20 20:19     ` Phil Richards
2006-09-22 23:08   ` [PATCH] Fix buggy ref recording Petr Baudis
2006-09-23  0:44     ` Junio C Hamano
2006-09-23  1:16       ` Petr Baudis
2006-09-23  4:34         ` [PATCH] pack-refs: fix git_path() usage Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0609191407340.4388@g5.osdl.org \
    --to=torvalds@osdl.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).