From: Linus Torvalds <torvalds@osdl.org>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Gerrit Pape <pape@smarden.org>, git@vger.kernel.org
Subject: RE: [PATCH] Build on Debian GNU/Hurd
Date: Thu, 21 Sep 2006 10:53:53 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0609211050390.4388@g5.osdl.org> (raw)
In-Reply-To: <000001c6dda4$ad0b1ec0$c47eedc1@ramsay1.demon.co.uk>
On Thu, 21 Sep 2006, Ramsay Jones wrote:
>
> IMHO, setting the value in the Makefile, for systems that don't define
> PATH_MAX, is a much better solution. In fact, that is what I thought was
> already being done.
Well, considering that we _can_ test defines, why not just do it
automatically.
In other words, instead of this patch:
> > -
> > -#ifndef PATH_MAX
> > -# define PATH_MAX 4096
> > -#endif
> > +#include <limits.h>
Just make the code read
#include <limits.h>
/*
* Insane systems don't have a fixed PATH_MAX, it's POSIX
* compliant but not worth worrying about, so if we didn't
* get PATH_MAX from <limits.h>, just make up our own
*/
#ifndef PATH_MAX
# define PATH_MAX 4096
#endif
and after that we can just ignore the issue forever more.
The thing is, it's not like we even really _care_ what PATH_MAX is all
that deeply. We just want to get some random value that is reasonable.
Linus
next prev parent reply other threads:[~2006-09-21 17:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-15 12:58 [PATCH] Build on Debian GNU/Hurd Gerrit Pape
2006-09-15 15:47 ` Martin Waitz
2006-09-16 5:35 ` Junio C Hamano
2006-09-19 17:03 ` Gerrit Pape
2006-09-21 17:37 ` Ramsay Jones
2006-09-21 17:53 ` Linus Torvalds [this message]
2006-09-22 17:22 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0609211050390.4388@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=pape@smarden.org \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).