From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org, Adrian Bunk <bunk@stusta.de>
Subject: Re: [PATCH 1/3] diff --stat: allow custom diffstat output width.
Date: Thu, 28 Sep 2006 13:54:27 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0609281349110.3952@g5.osdl.org> (raw)
In-Reply-To: <7vr6xyjal0.fsf@assigned-by-dhcp.cox.net>
On Tue, 26 Sep 2006, Junio C Hamano wrote:
>
> This adds two parameters to "diff --stat".
>
> . --stat-width=72 tells that the page should fit on 72-column output.
>
> . --stat-name-width=30 tells that the filename part is limited
> to 30 columns.
Thinking some more about this, I have to say, I do hate the syntax.
It may be clear thanks to being verbose, but it's _hell_ to write.
It has the same problem the "--stat-with-patch" argument had: sure, it
worked, but it was really really inconvenient, and just doing a
combination of "--stat -p" is much nicer.
So how about just extending the existing "--stat" thing, and just making
it do something like
git diff --stat=72,30
instead (perhaps along with a config option to set the defaults to
something else if we want to).
What do you think?
I'm just pretty sure I will never _ever_ bother to type
--stat-name-width=30 in my life except right now to complain about it. I
just can't see myself ever caring _that_ much. But "--stat=100" to see a
wider stat, that I could see myself doing. Or "--stat=100,100" if I want
to see long filenames too.
Linus
next prev parent reply other threads:[~2006-09-28 20:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-27 2:40 [PATCH 1/3] diff --stat: allow custom diffstat output width Junio C Hamano
2006-09-27 3:11 ` David Rientjes
2006-09-28 20:54 ` Linus Torvalds [this message]
2006-09-28 21:27 ` Junio C Hamano
2006-09-28 22:07 ` Linus Torvalds
2006-09-29 1:35 ` Junio C Hamano
2006-09-29 5:26 ` Junio C Hamano
2006-09-29 5:58 ` Linus Torvalds
2006-09-29 6:11 ` Junio C Hamano
2006-09-29 6:17 ` Linus Torvalds
2006-09-28 22:24 ` Adrian Bunk
2006-09-28 22:26 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0609281349110.3952@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=bunk@stusta.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).