From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] pack-refs: use lockfile as everybody else does.
Date: Wed, 4 Oct 2006 19:55:42 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0610041954480.3952@g5.osdl.org> (raw)
In-Reply-To: <7v7izhrc2v.fsf@assigned-by-dhcp.cox.net>
On Tue, 3 Oct 2006, Junio C Hamano wrote:
>
> Also I am not sure about the "fsync(fd); fclose(refs_file)"
> sequence I did not touch with this patch. Doesn't stdio still
> have stuff buffered when you run fsync()? Would adding fflush()
> in between help?
Yes, there should be a fflush() there before the fsync.
Linus
next prev parent reply other threads:[~2006-10-05 2:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-03 9:19 [PATCH] pack-refs: use lockfile as everybody else does Junio C Hamano
2006-10-05 2:55 ` Linus Torvalds [this message]
2006-10-05 6:15 ` Junio C Hamano
2006-10-05 14:51 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0610041954480.3952@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).