git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Junio C Hamano <junkio@cox.net>,
	dwmw2@infradead.org, git@vger.kernel.org
Subject: Re: Approxidate licensing
Date: Tue, 10 Oct 2006 11:17:36 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0610101102560.3952@g5.osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0610101246241.9789@iabervon.org>



On Tue, 10 Oct 2006, Daniel Barkalow wrote:
> 
> Would the three of you agree to license date.c under the LGPL or BSD? It 
> looks like you're the only authors of non-trivial changes [1]. And it seems 
> reasonable to want the date parsing thing under non-GPL terms outside of 
> git.

I'm not a huge fan of the LGPL, especially with the recent issues of 
GPLv3. The reason? The LGPL is expressly designed to be compatible with 
the GPL, but it's designed to be compatible with any version (and you 
can't limit it, the way you can the real GPL).

So you can take LGPL 2.1 code, and relicense it under GPLv3, and make 
changes to it, and those changes won't be available to a GPLv2 project.

That said, I don't think the date.c code is all that important, and I 
don't see why anybody would do something nasty like that anyway, so I 
guess I don't actually care. A lot of the approxidate code was actually 
written as a joke, and it will parse just about anything without any 
error, and without telling you that it returned a date that may not make 
any sense at all.

For example, currently

	./test-date "$(cat date.c)"

returns

	Tue Nov 30 11:58:59 1937

for me, but don't ask me why. It's just put together the random numbers 
and month-names embedded in the source and made some insane decision that 
it must be a date (since you told it so). And it never returned an error.

Some other things are just silly and not even correct

	./test-date "One year ago yesterday at tea-time"

which doesn't even give the right answer (because it will go _backwards_ 
to tea-time on Oct 8th, even though it obviously _should_ return "Oct 9, 
17:00". I don't have the energy to try to fix it.

It also needs this important patch to be complete. I don't know how this 
could ever have fallen through the cracks!

		Linus
---
diff --git a/date.c b/date.c
index 1825922..0b06994 100644
--- a/date.c
+++ b/date.c
@@ -657,6 +657,7 @@ static const struct typelen {
 	{ "hours", 60*60 },
 	{ "days", 24*60*60 },
 	{ "weeks", 7*24*60*60 },
+	{ "fortnights", 2*7*24*60*60 },
 	{ NULL }
 };	
 

  reply	other threads:[~2006-10-10 18:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-10 17:39 Approxidate licensing Daniel Barkalow
2006-10-10 18:17 ` Linus Torvalds [this message]
     [not found] ` <1073a5540610101128q3fb9f68fsf3a28fbda20927d1@mail.gmail.com>
2006-10-10 18:33   ` Edesio Costa e Silva
2006-10-10 19:23 ` Junio C Hamano
2006-10-10 20:54   ` Junio's wishes [Was: Re: Approxidate licensing] Horst H. von Brand
2006-10-10 22:12     ` Linus Torvalds
2006-10-11  7:55 ` Approxidate licensing Junio C Hamano
2006-10-11  7:57 ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0610101102560.3952@g5.osdl.org \
    --to=torvalds@osdl.org \
    --cc=barkalow@iabervon.org \
    --cc=dwmw2@infradead.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).