From: Linus Torvalds <torvalds@osdl.org>
To: Eran Tromer <git2eran@tromer.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] repack: allow simultaneous packing and pruning
Date: Tue, 10 Oct 2006 15:27:13 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0610101524050.3952@g5.osdl.org> (raw)
In-Reply-To: <452C19FC.7030001@tromer.org>
On Wed, 11 Oct 2006, Eran Tromer wrote:
>
> How so? This process loses the unreferenced objects from the old packs,
> where "referenced" is determined in a racy way. Same problem.
No.
Those unreferenced objects are old history that won't be part of any new
history.
If you create new history, they won't be in the pack.
It's obviously possible that you create new history that has a blob that
is equal to some old history (and no loose object will be created), but by
then we're _really_ reaching.
> But "git prune" does not GC packs, only loose objects.
Right. And you'd want to repack _and_ prune, but they should be kept
separate, because one is safe, the other is not.
Of course, if the code were to check that no references have changed over
the operation, then I wouldn't have any objections.
Linus
next prev parent reply other threads:[~2006-10-10 22:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-10 10:14 [PATCH] repack: allow simultaneous packing and pruning Sam Vilain
2006-10-10 11:04 ` Sam Vilain
2006-10-10 15:03 ` Linus Torvalds
2006-10-10 19:46 ` Eran Tromer
2006-10-10 21:25 ` Linus Torvalds
2006-10-10 22:09 ` Eran Tromer
2006-10-10 22:27 ` Linus Torvalds [this message]
2006-10-10 23:45 ` Eran Tromer
2006-10-10 20:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0610101524050.3952@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git2eran@tromer.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).