From: Linus Torvalds <torvalds@osdl.org>
To: Jim Meyering <jim@meyering.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] xdiff/xemit.c (xdl_find_func): Elide trailing white space in a context header.
Date: Mon, 23 Oct 2006 13:49:37 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0610231347490.3962@g5.osdl.org> (raw)
In-Reply-To: <87y7r63hq6.fsf@rho.meyering.net>
On Mon, 23 Oct 2006, Jim Meyering wrote:
>
> This removes trailing blanks from git-generated diff headers
> the same way a similar patch did that for GNU diff:
NO!
This is _wrong_
You should only remove the space IF IT IS THE ONLY THING ON THE WHOLE
LINE!
You must not remove white-space in general.
So the patch should check something like
if (len == 1 && rec[0] == ' ')
len = 0;
and not like you did it.
Otherwise the patch will simply not even _apply_.
Linus
next prev parent reply other threads:[~2006-10-23 20:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-23 20:22 [PATCH] xdiff/xemit.c (xdl_find_func): Elide trailing white space in a context header Jim Meyering
2006-10-23 20:49 ` Linus Torvalds [this message]
2006-10-23 21:03 ` Petr Baudis
2006-10-23 21:10 ` Linus Torvalds
2006-10-23 21:15 ` Jakub Narebski
2006-10-23 21:06 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0610231347490.3962@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=jim@meyering.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).