From: Nicolas Pitre <nico@cam.org>
To: Shawn Pearce <spearce@spearce.org>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] Teach receive-pack how to keep pack files based on object count.
Date: Tue, 31 Oct 2006 17:06:47 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.0610311659310.11384@xanadu.home> (raw)
In-Reply-To: <20061031212942.GA24184@spearce.org>
On Tue, 31 Oct 2006, Shawn Pearce wrote:
> Nicolas Pitre <nico@cam.org> wrote:
> > I used "pack" <tab> <sha1> so it is easy to pick out of the list of refs
> > that usually comes over the stream in the fetch case (if I understood
> > that part right).
>
> I thought about using a pipe too, but in the case of receive-pack
> it looked like index-pack was sending something back to the push
> end of the connection. I didn't dig into the code enough to see
> what that was and how to do the same in receive-pack itself.
Well, I think it goes like this:
unpack-objects (and now index-pack --stdin) reads from stdin in 4kb
chunks. When the pack has been entirely parsed, it is possible that the
4kb chunk contains data from the stream past the actual pack data which
is why the remaining of the buffer is flushed out to stdout for the next
tool in the chain to pick up.
So if you use a pipe with index-pack to retrieve the pack name, you also
must consume all extra data from it and pass it on as well.
next prev parent reply other threads:[~2006-10-31 22:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-31 7:57 [PATCH 2/2] Teach receive-pack how to keep pack files based on object count Shawn Pearce
2006-10-31 19:56 ` Nicolas Pitre
2006-10-31 20:11 ` Shawn Pearce
2006-10-31 21:08 ` Nicolas Pitre
2006-10-31 21:29 ` Shawn Pearce
2006-10-31 22:06 ` Nicolas Pitre [this message]
2006-10-31 22:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0610311659310.11384@xanadu.home \
--to=nico@cam.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).