From: Nicolas Pitre <nico@cam.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 6/6] remove .keep pack lock files when done with refs update
Date: Thu, 02 Nov 2006 12:25:56 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.0611021218510.11384@xanadu.home> (raw)
In-Reply-To: <Pine.LNX.4.64.0611020959410.11384@xanadu.home>
On Thu, 2 Nov 2006, Nicolas Pitre wrote:
> Another area of that patch I'm not really sure of is this:
>
> @@ -408,6 +415,7 @@ fetch_main () {
> append_fetch_head "$sha1" "$remote" \
> "$remote_name" "$remote_nick" "$local_name" "$not_for_merge"
> done
> + if [ "$pack_lockfile" ]; then rm -f "$pack_lockfile"; fi
> ) || exit ;;
> esac
>
> How can I make sure to not clobber a non-zero return code with the rm
> that would prevent the exit while still performing the rm in all cases?
OK looking at it again I think the || exit is only meant to match the
exit 1 before that point. Since this is a subshell then the exit 1
wouldn't exit it all on its own. Otherwise there is no errors expected
to trickle out of the while loop and I _think_ the above is correct.
Do you still want a new patch for the micronit quoting issue?
next prev parent reply other threads:[~2006-11-02 17:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 22:06 [PATCH 1/6] Allow pack header preprocessing before unpack-objects/index-pack Nicolas Pitre
2006-11-01 22:06 ` [PATCH 2/6] Teach receive-pack how to keep pack files based on object count Nicolas Pitre
2006-11-01 22:06 ` [PATCH 3/6] git-fetch can use both --thin and --keep with fetch-pack now Nicolas Pitre
2006-11-01 22:06 ` [PATCH 4/6] improve fetch-pack's handling of kept packs Nicolas Pitre
2006-11-01 22:06 ` [PATCH 5/6] have index-pack create .keep file more carefully Nicolas Pitre
2006-11-01 22:06 ` [PATCH 6/6] remove .keep pack lock files when done with refs update Nicolas Pitre
2006-11-02 5:18 ` Shawn Pearce
2006-11-02 5:27 ` Junio C Hamano
2006-11-02 15:09 ` Nicolas Pitre
2006-11-02 17:25 ` Nicolas Pitre [this message]
2006-11-03 9:35 ` Junio C Hamano
2006-11-01 23:50 ` [PATCH 1/6] Allow pack header preprocessing before unpack-objects/index-pack Junio C Hamano
2006-11-02 3:58 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0611021218510.11384@xanadu.home \
--to=nico@cam.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).