From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.176.0/21 X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MSGID_FROM_MTA_HEADER,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 From: Nicolas Pitre Subject: Re: [PATCH 0/2] Making "git commit" to mean "git commit -a". Date: Thu, 30 Nov 2006 17:31:05 -0500 (EST) Message-ID: References: <7virgzuf38.fsf@assigned-by-dhcp.cox.net> <7vr6vmsnly.fsf@assigned-by-dhcp.cox.net> <87ejrlvn7r.wl%cworth@cworth.org> <7vodqpn3t4.fsf@assigned-by-dhcp.cox.net> <7vk61dn2yj.fsf@assigned-by-dhcp.cox.net> <456EBBE7.8030404@op5.se> <20061130164046.GB17715@thunk.org> <87irgwu6e6.wl%cworth@cworth.org> <87hcwgu5t1.wl%cworth@cworth.org> <878xhsty3t.wl%cworth@cworth.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Content-Transfer-Encoding: 7BIT NNTP-Posting-Date: Thu, 30 Nov 2006 22:31:45 +0000 (UTC) Cc: Jakub Narebski , git@vger.kernel.org Return-path: Envelope-to: gcvg-git@gmane.org In-reply-to: <878xhsty3t.wl%cworth@cworth.org> X-X-Sender: nico@xanadu.home Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GpuR1-0006Oh-D2 for gcvg-git@gmane.org; Thu, 30 Nov 2006 23:31:16 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031576AbWK3WbK (ORCPT ); Thu, 30 Nov 2006 17:31:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1031578AbWK3WbK (ORCPT ); Thu, 30 Nov 2006 17:31:10 -0500 Received: from relais.videotron.ca ([24.201.245.36]:41952 "EHLO relais.videotron.ca") by vger.kernel.org with ESMTP id S1031576AbWK3WbG (ORCPT ); Thu, 30 Nov 2006 17:31:06 -0500 Received: from xanadu.home ([74.56.106.175]) by VL-MH-MR002.ip.videotron.ca (Sun Java System Messaging Server 6.2-2.05 (built Apr 28 2005)) with ESMTP id <0J9K00LM9EJTX7M0@VL-MH-MR002.ip.videotron.ca> for git@vger.kernel.org; Thu, 30 Nov 2006 17:31:05 -0500 (EST) To: Carl Worth Sender: git-owner@vger.kernel.org On Thu, 30 Nov 2006, Carl Worth wrote: > It might even make sense to invent one more name for the case where > the user wants to inform git that a file has been edited and that git > should accept the new contents. It's the sort of "note that file is > edited" operation that could be recommended to the user with "add; fix > typo; commit" confusion. > > Sure, "add" could be used again, and "update-index" clearly _works_ > but it's a rather ugly name, (and already has "plumbing" functionality > like --add and --remove that we don't want here). I disagree. "add" is beautiful. It is short, easy to remember, and transcend pretty much what the index is all about. And just because "add" and "edited" can be made into the same command is a pretty damn good reason not to create a separate command. You "add" changes to the changeset then you commit that changeset. No need to care whether or not this is a new file, an edited file, etc.