From: Linus Torvalds <torvalds@osdl.org>
To: Sean <seanlkml@sympatico.ca>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] Colourise git-branch output
Date: Mon, 11 Dec 2006 19:39:58 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0612111936240.6452@woody.osdl.org> (raw)
In-Reply-To: <BAYC1-PASMTP092A9E80667F373BF69AA6AED70@CEZ.ICE>
On Mon, 11 Dec 2006, Sean wrote:
>
> Technically it is workable.. but why even start down the road of having
> anything but branch names after a "branch."? There has to be a better
> spot for this variable, and it makes it more future proof, as you
> highlighted.
I do agree with Sean, both for the stability reason, but perhaps even more
because I personally think it would just be better to have a separate
"[color]" subsection.
In fact, I'd almost prefer to see
[color]
diff = auto
over
[diff]
color = auto
exactly because once we have different things that take colorization
arguments, it's just nicer to have them all together (and we already have
"status", and now we're getting "branch" too.
next prev parent reply other threads:[~2006-12-12 3:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-11 22:10 [PATCH] Colourise git-branch output Andy Parkins
2006-12-11 22:47 ` Junio C Hamano
2006-12-12 0:38 ` Sean
2006-12-12 1:11 ` Junio C Hamano
2006-12-12 1:24 ` Sean
2006-12-12 3:39 ` Linus Torvalds [this message]
2006-12-12 5:07 ` Junio C Hamano
2006-12-12 5:41 ` Linus Torvalds
2006-12-12 7:58 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2006-12-12 6:41 Andy Parkins
2006-12-12 8:46 ` Johannes Sixt
2006-12-12 10:10 ` Junio C Hamano
2006-12-12 11:03 ` Andy Parkins
2006-12-12 18:43 ` Junio C Hamano
2006-12-12 18:43 ` Junio C Hamano
2006-11-03 10:52 [PATCH] Add support to git-branch to show local and remote branches Andy Parkins
2006-11-03 12:06 ` [PATCH] Colourise git-branch output Andy Parkins
2006-11-03 19:25 ` Junio C Hamano
2006-11-03 23:05 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0612111936240.6452@woody.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=seanlkml@sympatico.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).